fix(charts): align label vertically and add donutHeight/Width defaults - #2193
Merged
dlabaj merged 2 commits intoJun 10, 2019
Merged
fix(charts): align label vertically and add donutHeight/Width defaults#2193dlabaj merged 2 commits into
dlabaj merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://2193-pr-patternfly-react-patternfly.surge.sh |
Sorry, something went wrong.
dlabrecq
force-pushed
the
2191-2192-charts
branch
from
9933996 to
503351d
Compare
June 8, 2019 03:35
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #2193 +/- ##
==========================================
- Coverage 80.65% 80.45% -0.21%
==========================================
Files 660 660
Lines 8322 8343 +21
Branches 628 641 +13
==========================================
Hits 6712 6712
- Misses 1310 1331 +21
Partials 300 300
Continue to review full report at Codecov.
|
Sorry, something went wrong.
…donutWidth Fixes patternfly#2191 Fixes patternfly#2192
dlabrecq
force-pushed
the
2191-2192-charts
branch
from
503351d to
fd24990
Compare
June 8, 2019 13:10
dlabrecq
force-pushed
the
2191-2192-charts
branch
from
f413607 to
8390c82
Compare
June 9, 2019 14:08
TheRealJon
approved these changes
Jun 10, 2019
TheRealJon
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
tlabaj
approved these changes
Jun 10, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
dlabaj
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for donut utilization changes requested by @TheRealJon for use in OpenShift.
Fixes #2191
Fixes #2192
Fixes #2194
I was able to fix #2191 by setting capHeight (using a rem value) in order to help center the label vertically. I only use this when both title and subtitle are available -- not necessary for a single label. I've added a property so it may be overridden.
I was able to address #2192 by changing the default donutHeight and donutWidth properties to use the min. of the given SVG height or width. If height & width are not provided, the default theme property would be used.
With these changes, the user can just set the height and width properties. Similar to other charts, we'll set the donut size to match that.
This also works with the threshold chart. I've modified the dynamic chart to be 28px smaller than the static (threshold) chart by default. This is similar to innerRadius, where we set a default regardless of the chart size.
This probably covers most use cases where the width is larger to accommodate either a left or right aligned legend. Of course, it also works without any legends at all. Thus, allowing the user to more easily create different size charts.
For edge cases, the user can still override the donutHeight and donutWidth properties. There an example of this (below), where the overall SVG height and width are larger than donutHeight and donutWidth. In this particular example, the horizontal legend is wider than the chart's donutWidth, while the SVG is sized appropriately to accommodate both the chart and legend.