FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(react-table): Fix error Unknown event handler property `onCollapse`. by kunyan · Pull Request #2195 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(react-table): Fix error Unknown event handler property onCollapse. - #2195

Merged
redallen merged 1 commit into
patternfly:masterfrom
kunyan:react-table-on-collapse
Jun 10, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(react-table): Fix error Unknown event handler property onCollapse.#2195
redallen merged 1 commit into
patternfly:masterfrom
kunyan:react-table-on-collapse

Conversation

kunyan commented Jun 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What:

Remove rows and onCollapse from ..props

The recently collapse changes added some unknown props of table
Just remove it from ..props

Additional issues:

patternfly-build commented Jun 10, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2195-pr-patternfly-react-patternfly.surge.sh

priley86 commented Jun 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@kunyan thanks - i knew about this and was going to submit a fix today. Looks like you beat me to it ;)

Slight miss during rebase of latest eslint...

priley86 commented Jun 10, 2019

Copy link
Copy Markdown
Member

@kunyan do you mind updating snapshots yarn test:pf4 -u ?

kunyan force-pushed the react-table-on-collapse branch from c9228e6 to da2b520 Compare June 10, 2019 14:36

codecov-io commented Jun 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@a3e5de0). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2195   +/-   ##
=========================================
  Coverage          ?   80.45%           
=========================================
  Files             ?      660           
  Lines             ?     8343           
  Branches          ?      641           
=========================================
  Hits              ?     6712           
  Misses            ?     1331           
  Partials          ?      300
Flag Coverage Δ
#patternfly3 85.22% <ø> (?)
#patternfly4 75.78% <100%> (?)
#patternflymisc 95.68% <ø> (?)
Impacted Files Coverage Δ
...-4/react-table/src/components/Table/BodyWrapper.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e5de0...da2b520. Read the comment docs.

kunyan commented Jun 10, 2019

Copy link
Copy Markdown
Contributor Author

Snapshots updated, but looks CI not updated

redallen commented Jun 10, 2019

Copy link
Copy Markdown
Contributor

Travis isn't reporting it's status, but the build passed: https://travis-ci.org/patternfly/patternfly-react/builds/543763403

redallen merged commit 2cbdfb8 into patternfly:master Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
priley86 priley86 approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL