FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PF4 - use context api in page component by jschuler · Pull Request #2208 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

PF4 - use context api in page component - #2208

Merged
dlabaj merged 3 commits into
patternfly:masterfrom
jschuler:page-context
Jun 19, 2019
ConversationCommits (3)ChecksFiles changed
Merged

PF4 - use context api in page component#2208
dlabaj merged 3 commits into
patternfly:masterfrom
jschuler:page-context

Conversation

jschuler commented Jun 11, 2019

Copy link
Copy Markdown
Contributor

Closes: #2188

jschuler requested review from dlabaj and tlabaj June 11, 2019 13:46

patternfly-build commented Jun 11, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2208-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Jun 11, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@14d1d70). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2208   +/-   ##
=========================================
  Coverage          ?   80.27%           
=========================================
  Files             ?      658           
  Lines             ?     8252           
  Branches          ?      643           
=========================================
  Hits              ?     6624           
  Misses            ?     1326           
  Partials          ?      302
Flag Coverage Δ
#patternfly3 85.23% <ø> (?)
#patternfly4 75.82% <100%> (?)
Impacted Files Coverage Δ
...atternfly-4/react-core/src/components/Page/Page.js 56% <100%> (ø)
...fly-4/react-core/src/components/Page/PageHeader.js 90% <100%> (ø)
...ly-4/react-core/src/components/Page/PageSidebar.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d1d70...30bea49. Read the comment docs.

tlabaj reviewed Jun 13, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Page/PageHeader.js
)}
</div>
)}
{/* Hide for now until we have the context selector component */}

tlabaj Jun 13, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We have . context Selector. Why are we hiding this?

jschuler Jun 14, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This has been here since before the context selector got created. Perhaps we should update the page component now to support it? Should be in a separate PR though. @rachael-phillips

tlabaj Jun 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

agreed. We should do tis in a separate PR. @rachael-phillips I opened a separate issue (#2285) to track that work.

redallen previously approved these changes Jun 14, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix merge conflicts and I'll reapprove!

tlabaj closed this Jun 17, 2019
tlabaj reopened this Jun 17, 2019

patternfly-build commented Jun 19, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2208.surge.sh

tlabaj approved these changes Jun 19, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj approved these changes Jun 19, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 1251326 into patternfly:master Jun 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Page component isManagedSidebar does not work if wrapper components are used for the header and sidebar props

6 participants

Back | FazBrowse Home | New Git URL