FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Pagination): Pagination Component Typescript Conversion by nicolethoen · Pull Request #2256 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Pagination): Pagination Component Typescript Conversion - #2256

Merged
tlabaj merged 12 commits into
patternfly:masterfrom
nicolethoen:pagination_ts_conversion
Jul 2, 2019
ConversationCommits (12)ChecksFiles changed
Merged

feat(Pagination): Pagination Component Typescript Conversion#2256
tlabaj merged 12 commits into
patternfly:masterfrom
nicolethoen:pagination_ts_conversion

Conversation

nicolethoen commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Addresses issue 2115

Includes new demo and cypress tests

nicolethoen changed the title Pagination ts conversion feat(Pagination): Pagination Component Typescript Conversion Jun 13, 2019

patternfly-build commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2256-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Jun 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@2107ebf). Click here to learn what that means.
The diff coverage is 75.89%.

@@            Coverage Diff            @@
##             master    #2256   +/-   ##
=========================================
  Coverage          ?   79.79%           
=========================================
  Files             ?      670           
  Lines             ?     8608           
  Branches          ?      790           
=========================================
  Hits              ?     6869           
  Misses            ?     1357           
  Partials          ?      382
Flag Coverage Δ
#patternfly3 85.23% <ø> (?)
#patternfly4 74.83% <75.89%> (?)
#patternflymisc 95.79% <ø> (?)
Impacted Files Coverage Δ
...y-4/react-core/src/components/Pagination/index.tsx 100% <100%> (ø)
...ckages/patternfly-4/react-core/src/helpers/util.ts 58.1% <100%> (ø)
...-core/src/components/Pagination/ToggleTemplate.tsx 42.85% <42.85%> (ø)
...t-core/src/components/Pagination/OptionsToggle.tsx 50% <50%> (ø)
...eact-core/src/components/Pagination/Navigation.tsx 73.17% <58.82%> (ø)
...eact-core/src/components/Pagination/Pagination.tsx 91.11% <86.66%> (ø)
...rc/components/Pagination/PaginationOptionsMenu.tsx 93.75% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2107ebf...df8cadd. Read the comment docs.

nicolethoen mentioned this pull request Jun 13, 2019
Merged

patternfly-build commented Jun 14, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2256-pr-patternfly-react-patternfly.surge.sh

redallen suggested changes Jun 14, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a ton!

Comment thread packages/patternfly-4/react-core/src/components/Pagination/PaginationOptionsMenu.tsx
Comment thread packages/patternfly-4/react-core/src/components/Pagination/OptionsToggle.tsx
Comment thread packages/patternfly-4/react-core/src/components/Pagination/OptionsToggle.tsx
Comment thread packages/patternfly-4/react-core/src/components/Pagination/PaginationOptionsMenu.tsx Outdated
nicolethoen force-pushed the pagination_ts_conversion branch 2 times, most recently from 1e6d39c to 2caea93 Compare June 18, 2019 15:25

patternfly-build commented Jun 18, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2256.surge.sh

redallen previously approved these changes Jun 18, 2019
View reviewed changes
rebeccaalpert previously approved these changes Jun 21, 2019
View reviewed changes

nicolethoen commented Jun 25, 2019

Copy link
Copy Markdown
Contributor Author

@tlabaj @dlabaj can I get a review from a senior dev on this?

nicolethoen dismissed stale reviews from rebeccaalpert and redallen via 601a7d9 June 25, 2019 13:09

nicolethoen commented Jun 25, 2019

Copy link
Copy Markdown
Contributor Author

@tlabaj @dlabaj nvm I did something wrong when I rebased. I'll ping you again when I have it sorted out

nicolethoen force-pushed the pagination_ts_conversion branch from 601a7d9 to 3abc4c3 Compare June 25, 2019 13:29

nicolethoen commented Jun 25, 2019

Copy link
Copy Markdown
Contributor Author

@dlabaj @tlabaj okay, sorry for the blast of notifications, but I think it's ready for review now. my rebasing did lose @rebeccaalpert and @redallen's approvals

redallen suggested changes Jun 25, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just one change left, thanks!

Comment thread packages/patternfly-4/react-core/src/components/Pagination/Navigation.tsx Outdated
nicolethoen force-pushed the pagination_ts_conversion branch from 4fe1a51 to dd616a8 Compare July 1, 2019 14:43

dlabrecq commented Jul 1, 2019

Copy link
Copy Markdown
Member

I attempted to test this with Cost Management, but the Tippy issue is getting in the way. If you can rebase after the release is fixed, I'll test again.

nicolethoen force-pushed the pagination_ts_conversion branch from dd616a8 to df8cadd Compare July 1, 2019 19:37

nicolethoen commented Jul 1, 2019

Copy link
Copy Markdown
Contributor Author

@dlabrecq done

dlabrecq approved these changes Jul 2, 2019
View reviewed changes

dlabrecq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

I built and installed the changes with Cost Management. I don't see any compile errors or issues in the browser console.

redallen approved these changes Jul 2, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Glad you managed to get some bugfixes in here too!

redallen commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Will merge after the latest prerelease gets promoted.

jessiehuff approved these changes Jul 2, 2019
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! :)

tlabaj approved these changes Jul 2, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 8a29a20 into patternfly:master Jul 2, 2019
nicolethoen deleted the pagination_ts_conversion branch February 8, 2023 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rebeccaalpert rebeccaalpert left review comments
jschuler Awaiting requested review from jschuler
dlabaj Awaiting requested review from dlabaj
+4 more reviewers
dlabrecq dlabrecq approved these changes
jessiehuff jessiehuff approved these changes
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jschuler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL