FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ApplicationLauncher): Adjust cypress test by jessiehuff · Pull Request #2263 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(ApplicationLauncher): Adjust cypress test - #2263

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
jessiehuff:fix/appLauncherTest
Jun 17, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(ApplicationLauncher): Adjust cypress test#2263
tlabaj merged 1 commit into
patternfly:masterfrom
jessiehuff:fix/appLauncherTest

Conversation

jessiehuff commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Fixes #2243

patternfly-build commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2263-pr-patternfly-react-patternfly.surge.sh

jessiehuff requested a review from tlabaj June 13, 2019 18:15

codecov-io commented Jun 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2263 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2263   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files         669      669           
  Lines        8529     8529           
  Branches      734      734           
=======================================
  Hits         6814     6814           
  Misses       1362     1362           
  Partials      353      353
Flag Coverage Δ
#patternfly3 85.23% <ø> (ø) ⬆️
#patternfly4 74.92% <ø> (ø) ⬆️
#patternflymisc 95.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4c491...b16b952. Read the comment docs.

redallen approved these changes Jun 14, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Page/PageHeader.d.ts
avatar?: ReactNode;
topNav?: ReactNode;
linkComponent?: ReactNode;
logoComponent?: ReactNode;

redallen Jun 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This one is my fault, sorry!

tlabaj Jun 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

why is prop name changing here?

jessiehuff Jun 18, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Zack asked me to include this based on: #2117

tlabaj approved these changes Jun 17, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 28a08ca into patternfly:master Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix Application Launcher cypress Tests

5 participants

Back | FazBrowse Home | New Git URL