FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Page): add page section main nav type variant by kmcfaul · Pull Request #2268 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Page): add page section main nav type variant - #2268

Merged
redallen merged 4 commits into
patternfly:masterfrom
kmcfaul:fix-page-main-nav
Jun 27, 2019
ConversationCommits (4)ChecksFiles changed
Merged

feat(Page): add page section main nav type variant#2268
redallen merged 4 commits into
patternfly:masterfrom
kmcfaul:fix-page-main-nav

Conversation

kmcfaul commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

What: Adding missing page main nav section

Refer to issue: #1742

patternfly-build commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2268-pr-patternfly-react-patternfly.surge.sh

codecov-io commented Jun 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@a5d571e). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2268   +/-   ##
=========================================
  Coverage          ?   79.89%           
=========================================
  Files             ?      669           
  Lines             ?     8531           
  Branches          ?      734           
=========================================
  Hits              ?     6816           
  Misses            ?     1362           
  Partials          ?      353
Flag Coverage Δ
#patternfly3 85.23% <ø> (?)
#patternfly4 74.93% <100%> (?)
#patternflymisc 95.79% <ø> (?)
Impacted Files Coverage Δ
...ly-4/react-core/src/components/Page/PageSection.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d571e...b926e4f. Read the comment docs.

boaz0 previously approved these changes Jun 14, 2019
View reviewed changes
redallen suggested changes Jun 14, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is in conflict with #2240 . Let's wait for that to get in (it's huge) and then rebase.

kmcfaul force-pushed the fix-page-main-nav branch from 9c68da7 to 3e670a7 Compare June 26, 2019 14:12

patternfly-build commented Jun 26, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2268.surge.sh

tlabaj requested a review from srambach June 27, 2019 17:00
tlabaj suggested changes Jun 27, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Page/PageSection.tsx Outdated
className?: string;
/** Section background color variant */
variant?: 'default' | 'light' | 'dark' | 'darker' | PageSectionVariants
variant?: 'default' | 'light' | 'dark' | 'darker' | PageSectionVariants;

tlabaj Jun 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why are we adding the enum to union here? I don't think it is needed.

kmcfaul Jun 27, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This came in from the TS conversion, which I followed for the type prop I added. Should I remove the enums and just leave the unions?

Edit: Talked with @redallen and I removed them. It's not really needed.

tlabaj requested a review from jschuler June 27, 2019 17:03
jschuler reviewed Jun 27, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Page/PageSection.tsx
/** Section background color variant */
variant?: 'default' | 'light' | 'dark' | 'darker' | PageSectionVariants
variant?: 'default' | 'light' | 'dark' | 'darker';
/** Section type variant */

jschuler Jun 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

when should consumers use nav? should there be an example? maybe a little more descriptive comment?

tlabaj Jun 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed. There is no example in core. @srambach will be opening up an additional issue to add one.

srambach commented Jun 27, 2019

Copy link
Copy Markdown
Member

Results look good to me 👍

tlabaj approved these changes Jun 27, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen merged commit 0c0d4a0 into patternfly:master Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srambach Awaiting requested review from srambach
4 more reviewers
jschuler jschuler left review comments
tlabaj tlabaj approved these changes
redallen redallen approved these changes
boaz0 boaz0 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

jessiehuff

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL