fix(Radio): fix warning from undefined starting params - #2292
Merged
jschuler merged 2 commits intoJun 27, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2292.surge.sh |
Sorry, something went wrong.
redallen
approved these changes
Jun 18, 2019
jschuler
reviewed
Jun 27, 2019
| disabled={isDisabled} | ||
| checked={checked || isChecked} | ||
| defaultChecked={isChecked ? undefined : defaultChecked} | ||
| {...!isChecked && { defaultChecked }} |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
defaultChecked is an attribute passed to input? what does it do?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I think it's required for the uncontrolled version of radio. The undefined was throwing a console error.
Sorry, something went wrong.
jschuler
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fixes warning re: controlled/uncontrolled switch. Also fixes warning for missing prop on uncontrolled radio.
Refer to issue: #2028