FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(Grid): Update grid layout to support new 2xl breakpoint by jessiehuff · Pull Request #2305 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(Grid): Update grid layout to support new 2xl breakpoint - #2305

Merged
dlabaj merged 6 commits into
patternfly:masterfrom
jessiehuff:fix/gridBreakpoints
Jun 27, 2019
ConversationCommits (6)ChecksFiles changed
Merged

fix(Grid): Update grid layout to support new 2xl breakpoint#2305
dlabaj merged 6 commits into
patternfly:masterfrom
jessiehuff:fix/gridBreakpoints

Conversation

jessiehuff commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Fixes #2199

Update the grid layout to support the 2xl breakpoint added here - patternfly/patternfly#1880

jessiehuff requested a review from mcoker June 19, 2019 18:16

patternfly-build commented Jun 19, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2305.surge.sh

mcoker reviewed Jun 19, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/layouts/Grid/Grid.js
/** the number of columns all grid items should span on a xLarge device */
xl: gridItemSpanValueShape,
/** the number of columns all grid items should span on a 2xLarge device */
xl2: gridItemSpanValueShape,

mcoker Jun 19, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should we call it 2xl or is there a reason it's xl2 here?

jessiehuff Jun 19, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I had to name it xl2 to meet JSX attribute name requirements. It won't allow a prop to start with a number. :(

boaz0 Jun 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe '2xl': gridItemSpanValueShape will make JSX happy?

jessiehuff Jun 21, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That works for defining the prop, but it doesn't work when actually creating a <GridItem 2xl={2}>

mcoker approved these changes Jun 21, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm! thanks!

tlabaj approved these changes Jun 27, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 2025c1c into patternfly:master Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
mcoker mcoker approved these changes
+2 more reviewers
boaz0 boaz0 left review comments
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update grid layout to support new 2xl breakpoint

6 participants

Back | FazBrowse Home | New Git URL