chore(Progress): Convert progress to TypeScript - #2307
Merged
jschuler merged 2 commits intoJun 27, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2307.surge.sh |
Sorry, something went wrong.
boaz0
previously approved these changes
Jun 20, 2019
kmcfaul
previously approved these changes
Jun 20, 2019
jschuler
reviewed
Jun 24, 2019
Comment thread
packages/patternfly-4/react-core/src/components/Progress/Progress.md
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Progress/Progress.tsx
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Progress/Progress.tsx
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Progress/ProgressBar.tsx
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Progress/ProgressContainer.tsx
Outdated
Comment thread
...atternfly-4/react-integration/demo-app-ts/src/components/demos/ProgressDemo/ProgressDemo.tsx
Outdated
Comment thread
...atternfly-4/react-integration/demo-app-ts/src/components/demos/ProgressDemo/ProgressDemo.tsx
Outdated
redallen
suggested changes
Jun 24, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I agree with Joachim's comments.
Sorry, something went wrong.
Comment thread
packages/patternfly-4/react-core/src/components/Progress/Progress.tsx
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Progress/index.ts
Outdated
redallen
previously approved these changes
Jun 25, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
tlabaj
previously approved these changes
Jun 27, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
tlabaj
reviewed
Jun 27, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
tlabaj
approved these changes
Jun 27, 2019
jschuler
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted progress to TypeScript.