FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(Switch): convert Switch to TypeScript by tlabaj · Pull Request #2311 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(Switch): convert Switch to TypeScript - #2311

Merged
redallen merged 4 commits into
patternfly:masterfrom
tlabaj:switch
Jul 2, 2019
ConversationCommits (4)ChecksFiles changed
Merged

chore(Switch): convert Switch to TypeScript#2311
redallen merged 4 commits into
patternfly:masterfrom
tlabaj:switch

Conversation

tlabaj commented Jun 20, 2019

Copy link
Copy Markdown
Contributor

#2019

What:

Additional issues:

patternfly-build commented Jun 20, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2311.surge.sh

redallen suggested changes Jun 24, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx Outdated
isDisabled?: boolean,
/** A callback for when the Switch selection changes. (isChecked, event) => {} */
onChange: PropTypes.func,
onChange?(checked: boolean, event: FormEvent<HTMLInputElement>): void;

redallen Jun 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Use an arrow function so the docs pick this up properly. Like `onChange?: (checked: boolean, event: FormEvent) => void;

Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx Outdated
jessiehuff suggested changes Jun 24, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
'aria-label': ''
};
export class Switch extends React.Component<SwitchProps> {
id = '';

jessiehuff Jun 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove this class attribute

dlabaj Jun 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure what the purpose of this id is ... is it suppose to be the same as props.id?

tlabaj Jul 2, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

it instantiates the id when it is generated. And there is no id prop set.

redallen Jul 2, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shouldn't it instantiate it as a defaultProp to getUniqueId()?

tlabaj Jul 2, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am not sure. Does it work differently in TS than JS. In JS if you set defaultProp to getUniqueId, if you had more hat one Switch on the page the id's would all be the same? That is why we had it in the constructor before.

dlabaj Jul 2, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like it will set it for all of the name to be the same based off the time. Leave it in the constructor.

Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
dlabaj reviewed Jun 25, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wondering what was the use case for that separate class attribute ID.

Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
'aria-label': ''
};
export class Switch extends React.Component<SwitchProps> {
id = '';

dlabaj Jun 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure what the purpose of this id is ... is it suppose to be the same as props.id?

dlabaj approved these changes Jul 2, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
'aria-label': ''
};
export class Switch extends React.Component<SwitchProps> {
id = '';

dlabaj Jul 2, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like it will set it for all of the name to be the same based off the time. Leave it in the constructor.

redallen merged commit dac87ba into patternfly:master Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
+2 more reviewers
jessiehuff jessiehuff approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL