fix(expandable): Add button type to the Expandable Component - #2340
Merged
dlabaj merged 2 commits intoJun 25, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Added type button without which the component acts like a submit button on a form
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2340.surge.sh |
Sorry, something went wrong.
dlabaj
reviewed
Jun 24, 2019
dlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks like you need to update your snapshots for the JEST tests.
Sorry, something went wrong.
redallen
approved these changes
Jun 25, 2019
tlabaj
approved these changes
Jun 25, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
dlabaj
approved these changes
Jun 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Added button type to the component, without which it acts like a submit button on a form.
Additional issues: None
Fixes: #2339