FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(charts): adds sparkline example and interpolation to area examples by dlabrecq · Pull Request #2373 · patternfly/patternfly-react · GitHub

fix(charts): adds sparkline example and interpolation to area examples - #2373

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2367-sparkline
Jun 27, 2019
Merged

fix(charts): adds sparkline example and interpolation to area examples#2373
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2367-sparkline

Conversation

Copy link
Copy Markdown
Member

This adds a sparkline example and interpolation (curved lines) to other area examples.

See https://www.patternfly.org/pattern-library/data-visualization/sparkline/

fixes #2367

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2373.surge.sh

boaz0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

dlabaj requested a review from TheRealJon June 27, 2019 17:37
dlabaj self-assigned this Jun 27, 2019
dlabaj requested a review from mcarrano June 27, 2019 17:40

mcarrano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great. Thanks for making these changes @dlabaj!

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit ac68f3f into patternfly:master Jun 27, 2019
dlabrecq deleted the 2367-sparkline branch July 2, 2019 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Sparkline example to Area chart

6 participants


Back | FazBrowse Home | New Git URL