feat(card): Add compact card variation - #2399
Merged
jschuler merged 9 commits intoJul 1, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2399.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks great @jessiehuff one thing though the headers in the card are set to pf-m-lg when they should be pf-m-md. 16px vs 18px.
|
Sorry, something went wrong.
jschuler
reviewed
Jun 28, 2019
Comment thread
packages/patternfly-4/react-core/src/components/Card/Card.md
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Card/Card.tsx
Outdated
christiemolloy
previously approved these changes
Jun 28, 2019
christiemolloy
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
redallen
previously approved these changes
Jun 28, 2019
jschuler
previously approved these changes
Jun 28, 2019
tlabaj
suggested changes
Jun 28, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can you update the cypress test as well.
Sorry, something went wrong.
jschuler
previously approved these changes
Jun 28, 2019
redallen
previously approved these changes
Jun 28, 2019
jschuler
reviewed
Jun 28, 2019
tlabaj
previously requested changes
Jun 28, 2019
Comment thread
packages/patternfly-4/react-integration/demo-app-ts/src/components/demos/CardDemo/CardDemo.tsx
Outdated
redallen
approved these changes
Jul 1, 2019
jschuler
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 more reviewersAssignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2392