FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(OptionsMenu): Add disabled modifier to the toggle by tlabaj · Pull Request #2401 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(OptionsMenu): Add disabled modifier to the toggle - #2401

Merged
jschuler merged 4 commits into
patternfly:masterfrom
tlabaj:options_menu
Jul 1, 2019
ConversationCommits (4)ChecksFiles changed
Merged

feat(OptionsMenu): Add disabled modifier to the toggle#2401
jschuler merged 4 commits into
patternfly:masterfrom
tlabaj:options_menu

Conversation

tlabaj commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

#2396

What:

Additional issues:

tlabaj requested review from dlabaj, kmcfaul and nicolethoen June 28, 2019 19:37

patternfly-build commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2401.surge.sh

tlabaj requested a review from christiemolloy June 28, 2019 20:30

christiemolloy commented Jul 1, 2019

Copy link
Copy Markdown
Member

@tlabaj when I click on the non-disabled plain dropdown, the disabled dropdown inherits the active color

redallen previously approved these changes Jul 1, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good on JS side.

jschuler reviewed Jul 1, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/OptionsMenu/OptionsMenu.md Outdated
const toggle = <OptionsMenuToggle onToggle={this.onToggle} toggleTemplate={toggleTemplate} aria-label="Sort by" hideCaret/>
const toggle = <OptionsMenuToggle onToggle={this.onDisabledToggle} toggleTemplate={toggleTemplate} aria-label="Sort by" hideCaret/>

const disabledToggle = <OptionsMenuToggle isDisabled onToggle={this.onToggle} toggleTemplate={toggleTemplate} aria-label="Sort by" hideCaret/>

jschuler Jul 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the onToggle here should be this.onDisabledToggle and the previous one should be this.onToggle?

jschuler Jul 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This will also address @christiemolloy 's comment

christiemolloy approved these changes Jul 1, 2019
View reviewed changes

christiemolloy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks for updating

jschuler merged commit c6693c1 into patternfly:master Jul 1, 2019
tlabaj mentioned this pull request Jul 1, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj Awaiting requested review from dlabaj
nicolethoen Awaiting requested review from nicolethoen
kmcfaul Awaiting requested review from kmcfaul
3 more reviewers
jschuler jschuler approved these changes
christiemolloy christiemolloy approved these changes
redallen redallen left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

nicolethoen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL