FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(grid): always remove size props from {...props} by redallen · Pull Request #2404 · patternfly/patternfly-react · GitHub

fix(grid): always remove size props from {...props} - #2404

Merged
redallen merged 1 commit into
patternfly:masterfrom
redallen:fix/grid-proptypes
Jul 1, 2019
Merged

fix(grid): always remove size props from {...props}#2404
redallen merged 1 commit into
patternfly:masterfrom
redallen:fix/grid-proptypes

Conversation

redallen commented Jun 28, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

What: Resolves #2403

Additional issues:

redallen changed the title fix(grid): always remove props from {...props} fix(grid): always remove size props from {...props} Jun 28, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2404.surge.sh

jessiehuff left a comment
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, glad you caught this!

dlabaj added the PF4 label Jul 1, 2019

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@redallen Can we get an issue created for this and linked to this PR. Thanks

dlabaj added the bug 🐛 label Jul 1, 2019

dlabrecq commented Jul 1, 2019

Copy link
Copy Markdown
Member

The issue would be #2403

redallen merged commit f549b95 into patternfly:master Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GridItem warnings

5 participants


Back | FazBrowse Home | New Git URL