fix(Modal): get modal container from state to set/unset aria-hidden - #2406
Merged
tlabaj merged 1 commit intoJul 2, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2406.surge.sh |
Sorry, something went wrong.
dlabaj
approved these changes
Jul 1, 2019
dlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@jgiardino Can you make sure this resolves any accessibility concerns. Thanks for the fix @boaz0
Sorry, something went wrong.
jenny-s51
approved these changes
Jul 2, 2019
jenny-s51
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Currently working on the same issue in AboutModal and this change looks good to me.
Sorry, something went wrong.
tlabaj
approved these changes
Jul 2, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for working on this, @boaz0!! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
fixes #2405
When displaying a modal both the children of the body and the modal container had aria-hidden=true. The problem was that the container that was compared with the children is not stored in this.container but in the state.
This PR fixes this problem.
//cc @jgiardino