feat(Pagination): Let users enter numbers into the input field - #2417
Merged
tlabaj merged 3 commits intoJul 11, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2417.surge.sh |
Sorry, something went wrong.
redallen
suggested changes
Jul 2, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This is awesome, thanks so much!
Sorry, something went wrong.
Comment thread
packages/patternfly-4/react-core/src/components/Pagination/Navigation.js
Outdated
Copy link
Copy Markdown
Member
Author
|
Refactored to work with Nicole's TypeScript conversion. |
Sorry, something went wrong.
redallen
reviewed
Jul 10, 2019
Comment thread
packages/patternfly-4/react-core/src/components/Pagination/Navigation.tsx
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Pagination/Navigation.tsx
Outdated
jschuler
reviewed
Jul 10, 2019
Comment thread
packages/patternfly-4/react-core/src/components/Pagination/Navigation.tsx
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Pagination/Navigation.tsx
Outdated
…hout highlighting the page numb Fixes #2344
Copy link
Copy Markdown
Member
Author
|
Addressed PR feedback. |
Sorry, something went wrong.
redallen
approved these changes
Jul 10, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM! 🥇
Sorry, something went wrong.
jessiehuff
approved these changes
Jul 11, 2019
jessiehuff
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM :)
Sorry, something went wrong.
tlabaj
approved these changes
Jul 11, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
AllenBW
added a commit
to AllenBW/insights-advisor-frontend
that referenced
this pull request
Aug 5, 2019
this changed here patternfly/patternfly-react#2417 (previous behavior was instant execution on any input)
AllenBW
added a commit
to RedHatInsights/insights-advisor-frontend
that referenced
this pull request
Aug 5, 2019
…#389) this changed here patternfly/patternfly-react#2417 (previous behavior was instant execution on any input)
ryelo
pushed a commit
to RedHatInsights/insights-advisor-frontend-build
that referenced
this pull request
Aug 5, 2019
… (#389) this changed here patternfly/patternfly-react#2417 (previous behavior was instant execution on any input)
ryelo
pushed a commit
to RedHatInsights/insights-advisor-frontend-build
that referenced
this pull request
Aug 5, 2019
… (#389) this changed here patternfly/patternfly-react#2417 (previous behavior was instant execution on any input)
ryelo
pushed a commit
to RedHatInsights/insights-advisor-frontend-build
that referenced
this pull request
Aug 5, 2019
… (#389) this changed here patternfly/patternfly-react#2417 (previous behavior was instant execution on any input)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 more reviewersAssignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now enter numbers into the input field without highlighting the page number in the input field. You have to hit enter in order for the change to go through and affect the dropdown/buttons. Non-integer inputs will default to the previous page number on enter.
Fixes #2344.