FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Select): add optional display via children to option by kmcfaul · Pull Request #2419 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Select): add optional display via children to option - #2419

Merged
redallen merged 5 commits into
patternfly:masterfrom
kmcfaul:select-custom-option
Jul 12, 2019
ConversationCommits (5)ChecksFiles changed
Merged

feat(Select): add optional display via children to option#2419
redallen merged 5 commits into
patternfly:masterfrom
kmcfaul:select-custom-option

Conversation

kmcfaul commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

What: Allows custom display of options via the children param.

Additional issues: #2370

patternfly-build commented Jul 1, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2419.surge.sh

redallen suggested changes Jul 2, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Select/CheckboxSelectOption.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Select/CheckboxSelectOption.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Select/SelectOption.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Select/SelectOption.tsx Outdated
Comment thread packages/patternfly-4/react-core/src/components/Select/SelectOption.tsx Outdated
tlabaj suggested changes Jul 2, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would also update the demo and integration test for this change.

Comment thread packages/patternfly-4/react-core/src/components/Select/CheckboxSelectOption.tsx Outdated

kmcfaul commented Jul 8, 2019

Copy link
Copy Markdown
Contributor Author

@tlabaj I had added some unit tests for the custom display, as I wasn't sure if we wanted to show the custom display in our demos. Which demo should I edit to use the children prop, or should I add another separate demo for it?

tlabaj commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

@kmcfaul I was talking about adding a demo to our integration app and adding cypress test.

tlabaj self-assigned this Jul 8, 2019
kmcfaul added 2 commits July 11, 2019 09:24
feat(Select): add example to ts demo, add cypress test, fix display o…
584e2cc 
…f selected item

when custom select option is used, the custom display should be shown on the selected item instead
of value
feat(Select): fix lint errors
40e9d0b

kmcfaul commented Jul 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Added logic so the custom option is displayed instead of value when selected, up in the toggle, if it is present.
Added logic so typeahead uses display text for default filtering. Custom filtering will be added in another PR.

Two examples have been added to the TypeScript demo - single and multi typeahead.

tlabaj approved these changes Jul 12, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen merged commit 03be1a7 into patternfly:master Jul 12, 2019

patternfly-build commented Jul 12, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.71.0
  • @patternfly/react-docs@4.8.75
  • @patternfly/react-inline-edit-extension@2.9.38
  • demo-app-ts@2.12.0
  • @patternfly/react-integration@2.12.0
  • @patternfly/react-table@2.14.12
  • @patternfly/react-topology@2.6.9
  • @patternfly/react-virtualized-extension@1.1.71

Thanks for your contribution! 🎉

tlabaj mentioned this pull request Jul 23, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL