FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Gallery): Convert gallery to typescript by jessiehuff · Pull Request #2432 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Gallery): Convert gallery to typescript #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 6 commits into from
Jul 5, 2019
Conversation 7 Commits 6 Checks 0 Files changed
Merged

feat(Gallery): Convert gallery to typescript #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9867499
Convert gallery to typescript
jessiehuff Jul 2, 2019
2b2000c
Add demo and integration tests
jessiehuff Jul 2, 2019
495c838
Merge upstream
jessiehuff Jul 2, 2019
3378744
Revert gutter
jessiehuff Jul 5, 2019
8eda0b1
Revert demo
jessiehuff Jul 5, 2019
01abacf
Update example
jessiehuff Jul 5, 2019
File filter

Filter by extension

Filter by extension .js  (3) .md  (1) .snap  (1) .ts  (7) .tsx  (4) All 5 file types selected
Deleted files Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
      • Gallery.d.ts
      • Gallery.js
      • Gallery.test.tsx
      • Gallery.tsx
      • GalleryItem.d.ts
      • GalleryItem.js
      • GalleryItem.tsx
        • Gallery.md
      • index.d.ts
      • index.js
      • index.ts
        • gallery.spec.ts
        • Demos.ts
            • GalleryDemo.tsx
          • index.ts
11 changes: 0 additions & 11 deletions packages/patternfly-4/react-core/src/layouts/Gallery/Gallery.d.ts
Show comments
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions packages/patternfly-4/react-core/src/layouts/Gallery/Gallery.js
Show comments
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...-core/src/layouts/Gallery/Gallery.test.js → ...core/src/layouts/Gallery/Gallery.test.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import Gallery from './Gallery';
import * as React from 'react';
import { Gallery } from './Gallery';
import { GutterSize } from '../../styles/gutters';
import { shallow } from 'enzyme';

Expand Down
25 changes: 25 additions & 0 deletions packages/patternfly-4/react-core/src/layouts/Gallery/Gallery.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import * as React from 'react';
import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/layouts/Gallery/gallery';

export interface GalleryProps extends React.HTMLProps<HTMLDivElement> {
/** content rendered inside the Gallery layout */
children?: React.ReactNode;
/** additional classes added to the Gallery layout */
className?: string;
/** Adds space between children. */
gutter?: 'sm' | 'md' | 'lg';
}
export const Gallery: React.FunctionComponent<GalleryProps> = ({
children = null,
className = '',
gutter = null,
...props
}: GalleryProps) => (
<div
className={css(styles.gallery, gutter && styles.modifiers.gutter, className)}
{...props}
>
{children}
</div>
);
7 changes: 0 additions & 7 deletions packages/patternfly-4/react-core/src/layouts/Gallery/GalleryItem.d.ts
Show comments
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions packages/patternfly-4/react-core/src/layouts/Gallery/GalleryItem.js
Show comments
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions packages/patternfly-4/react-core/src/layouts/Gallery/GalleryItem.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import * as React from 'react';

export interface GalleryItemProps extends React.HTMLProps<HTMLDivElement> {
/** content rendered inside the Gallery Item */
children?: React.ReactNode;
}

export const GalleryItem: React.FunctionComponent<GalleryItemProps> = ({
children = null,
...props
}: GalleryItemProps) => (
<div {...props}>{children}</div>
);
0 ...allery/__snapshots__/Gallery.test.js.snap → ...llery/__snapshots__/Gallery.test.tsx.snap
Show comments
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions packages/patternfly-4/react-core/src/layouts/Gallery/examples/Gallery.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ title: 'Gallery'
cssPrefix: 'pf-l-gallery'
section: 'layouts'
propComponents: ['Gallery', 'GalleryItem']
typescript: true
---

import { Gallery, GalleryItem } from '@patternfly/react-core';
Expand Down
2 changes: 0 additions & 2 deletions packages/patternfly-4/react-core/src/layouts/Gallery/index.d.ts
Show comments
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions packages/patternfly-4/react-core/src/layouts/Gallery/index.js
Show comments
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions packages/patternfly-4/react-core/src/layouts/Gallery/index.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from './Gallery';
export * from './GalleryItem';
14 changes: 14 additions & 0 deletions packages/patternfly-4/react-integration/cypress/integration/gallery.spec.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
describe('Gallery Demo Test', () => {
it('Navigate to demo section', () => {
cy.visit('http://localhost:3000/');
cy.get('#gallery-demo-nav-item-link').click();
cy.url().should('eq', 'http://localhost:3000/gallery-demo-nav-link');
});
it('Verify gallery item', () => {
cy.get('.pf-c-page__main-section').find('div').first().should('have.class', 'pf-l-gallery');
})

it('Verify gutters', () => {
cy.get('.pf-l-gallery').should('have.class', 'pf-m-gutter');
});
});
5 changes: 5 additions & 0 deletions packages/patternfly-4/react-integration/demo-app-ts/src/Demos.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ export const Demos: DemoInterface[] = [
name: 'Form Select Demo',
componentType: Examples.FormSelectDemo
},
{
id: 'gallery-demo',
name: 'Gallery Demo',
componentType: Examples.GalleryDemo
},
{
id: 'input-group-demo',
name: 'Input Group Demo',
Expand Down
17 changes: 17 additions & 0 deletions ...tternfly-4/react-integration/demo-app-ts/src/components/demos/GalleryDemo/GalleryDemo.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React from 'react';
import { Gallery, GalleryItem } from '@patternfly/react-core';

export class GalleryDemo extends React.Component {
render() {
return (
<Gallery gutter="md">
<GalleryItem>Gallery Item</GalleryItem>
<GalleryItem>Gallery Item</GalleryItem>
<GalleryItem>Gallery Item</GalleryItem>
<GalleryItem>Gallery Item</GalleryItem>
<GalleryItem>Gallery Item</GalleryItem>
<GalleryItem>Gallery Item</GalleryItem>
</Gallery>
)
}
}
7 changes: 4 additions & 3 deletions packages/patternfly-4/react-integration/demo-app-ts/src/components/demos/index.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ export * from './ClipboardCopyDemo/ClipboardCopyDemo';
export * from './ContextSelectorDemo/ContextSelectorDemo';
export * from './DataListDemo/DataListDemo';
export * from './EmptyStateDemo/EmptyStateDemo';
export * from './FormDemo/FormDemo';
export * from './FormSelectDemo/FormSelectDemo';
export * from './InputGroupDemo/InputGroupDemo';
export * from './FormDemo/FormDemo';
export * from './FormSelectDemo/FormSelectDemo';
export * from './GalleryDemo/GalleryDemo';
export * from './InputGroupDemo/InputGroupDemo';
export * from './LabelDemo/LabelDemo';
export * from './ListDemo/ListDemo';
export * from './LoginPageDemo/LoginPageDemo';
Expand Down
Back | FazBrowse Home | New Git URL