build(pr-comments): add PR comment on publish - #2433
Merged
jschuler merged 2 commits intoJul 5, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2433.surge.sh |
Sorry, something went wrong.
redallen
force-pushed
the
feat/pr-version-comments
branch
from
52af960 to
13278bc
Compare
July 2, 2019 19:03
Copy link
Copy Markdown
Member
|
@redallen - does this update a PR that has been merged or add the possible next versions for a PR that is still open? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@dgutride This adds a comment to a PR after it has been merged and successfully published. |
Sorry, something went wrong.
dgutride
approved these changes
Jul 5, 2019
jschuler
approved these changes
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Add comments on publishing a prerelease that lists the published versions. Example PR comment: #2433 (comment)
Additional issues: Also gently refactor upload-docs.sh to be parametrized.