FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Select): add select custom filter callback by kmcfaul · Pull Request #2434 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Select): add select custom filter callback - #2434

Merged
tlabaj merged 5 commits into
patternfly:masterfrom
kmcfaul:select-custom-filter
Jul 29, 2019
ConversationCommits (5)ChecksFiles changed
Merged

feat(Select): add select custom filter callback#2434
tlabaj merged 5 commits into
patternfly:masterfrom
kmcfaul:select-custom-filter

Conversation

kmcfaul commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

What: Adds a custom callback for the filtering function used in typeahead variants. This replaces the current search entirely, so the function must handle filtering the list of children/options and return the filtered results for the internal state to update.

Additional issues: #2369

patternfly-build commented Jul 2, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2434.surge.sh

tlabaj requested review from dlabaj and jschuler July 3, 2019 19:50
kmcfaul force-pushed the select-custom-filter branch from 4ef3717 to 6e3c6b0 Compare July 12, 2019 15:39
tlabaj previously approved these changes Jul 12, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj previously approved these changes Jul 24, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

LGTM, but noticed two other things:

  1. When i type something and filter down the results, and then close and reopen the dropdown (the filter text is still applied) it shows me the whole list again. Is this expected?
  2. When i start typing and the dropdown is closed, it does not automatically open. I would expect it to open

kmcfaul commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

  1. When you close the menu the filter resets. If you select an item, that is filled into the input but it isn't acting as a filter, and maybe that should change?

  2. is being addressed in a separate PR

kmcfaul force-pushed the select-custom-filter branch from 3e39d49 to fee95bd Compare July 26, 2019 15:48
tlabaj approved these changes Jul 29, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 878a107 into patternfly:master Jul 29, 2019

patternfly-build commented Jul 29, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.78.0
  • @patternfly/react-docs@4.9.9
  • @patternfly/react-inline-edit-extension@2.9.55
  • demo-app-ts@2.13.3
  • @patternfly/react-table@2.15.3
  • @patternfly/react-topology@2.7.4
  • @patternfly/react-virtualized-extension@1.1.88

Thanks for your contribution! 🎉

karelhala mentioned this pull request Jul 30, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj Awaiting requested review from dlabaj
3 more reviewers
redallen redallen left review comments
jschuler jschuler approved these changes
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jschuler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL