FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Chart: Add bottom-left legend position by dlabrecq · Pull Request #2442 · patternfly/patternfly-react · GitHub

Chart: Add bottom-left legend position - #2442

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2441-legend-left
Jul 10, 2019
Merged

Chart: Add bottom-left legend position#2442
tlabaj merged 1 commit into
patternfly:masterfrom
dlabrecq:2441-legend-left

Conversation

dlabrecq commented Jul 3, 2019

Copy link
Copy Markdown
Member

Cost Management needs to align legends on the bottom-left, for its area charts. This change adds support for a bottom-left aligned legend.

fixes #2441

dlabrecq force-pushed the 2441-legend-left branch from 5027383 to 53c1594 Compare July 3, 2019 15:03

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2442.surge.sh

tlabaj added PF4 labels Jul 3, 2019
tlabaj requested a review from TheRealJon July 5, 2019 14:23

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix merge conflicts and this is good 👍

dlabrecq force-pushed the 2441-legend-left branch from 53c1594 to c798f29 Compare July 9, 2019 02:34
dlabrecq removed the request for review from TheRealJon July 10, 2019 13:49
redallen changed the title Charft: Add bottom-left legend position Chart: Add bottom-left legend position Jul 10, 2019

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tlabaj merged commit 1f52911 into patternfly:master Jul 10, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@4.5.0

Thanks for your contribution! 🎉

dlabrecq deleted the 2441-legend-left branch July 17, 2019 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charts: Need bottom-left legend position

4 participants


Back | FazBrowse Home | New Git URL