FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Grid): Convert grid to typescript by jessiehuff · Pull Request #2443 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Grid): Convert grid to typescript - #2443

Merged
redallen merged 13 commits into
patternfly:masterfrom
jessiehuff:feat/gridTS
Jul 10, 2019
ConversationCommits (13)ChecksFiles changed
Merged

feat(Grid): Convert grid to typescript#2443
redallen merged 13 commits into
patternfly:masterfrom
jessiehuff:feat/gridTS

Conversation

jessiehuff commented Jul 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2447

patternfly-build commented Jul 3, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2443.surge.sh

tlabaj suggested changes Jul 3, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/layouts/Grid/Grid.tsx Outdated
tlabaj added Breaking change 💥 this change requires a major release and has API changes. Do Not Merge labels Jul 3, 2019
tlabaj suggested changes Jul 8, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We are missing demo and integration test here..

Comment thread packages/patternfly-4/react-core/src/components/Title/Title.test.tsx Outdated
test(`${size} Title`, () => {
const view = shallow(
<Title size={size} headingLevel={TitleLevel.h1}>
<Title size={size as 'xs' | 'sm' | 'md' | 'lg' | 'xl' | '2xl' | '3xl' | '4xl'} headingLevel={TitleLevel.h1}>

tlabaj Jul 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

does the Title.h1 work here? Or do we have to use the string?

jessiehuff Jul 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, it should still work. :)

tlabaj Jul 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay, butwhy are we changing this as part of the Grid conversion?

jessiehuff Jul 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was running into some errors with the tests, and this was my workaround at the time. I think I found a way that we can keep the previous code.

tlabaj suggested changes Jul 8, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/styles/sizes.ts Outdated
md: 'Md',
lg: 'Lg',
xl: 'Xl',
xl2: '_2xl'

tlabaj Jul 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why did we change the definition of the const here?

jessiehuff Jul 8, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is to build the prop names from react-styles correctly.

tlabaj removed Breaking change 💥 this change requires a major release and has API changes. Do Not Merge labels Jul 8, 2019
tlabaj suggested changes Jul 9, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/EmptyState/EmptyState.test.tsx
Comment thread packages/patternfly-4/react-core/src/components/Popover/PopoverHeader.tsx
Comment thread packages/patternfly-4/react-core/src/components/Title/Title.test.tsx Outdated
test(`${size} Title`, () => {
const view = shallow(
<Title size={size} headingLevel={TitleLevel.h1}>
<Title size={size as 'xs' | 'sm' | 'md' | 'lg' | 'xl' | '2xl' | '3xl' | '4xl'} headingLevel={TitleLevel.h1}>

tlabaj Jul 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Okay, butwhy are we changing this as part of the Grid conversion?

tlabaj approved these changes Jul 10, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

redallen approved these changes Jul 10, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice refactor.

redallen merged commit d4f8231 into patternfly:master Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
tlabaj tlabaj approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert Grid to Typescript

4 participants

Back | FazBrowse Home | New Git URL