fix(BreadCrumbSwitcher): Fix Autocomplete camelCase - #2457
Merged
jeff-phillips-18 merged 1 commit intoJul 9, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
React requires camelCase for DOM attributes, we need to change autocomplete to autoComplete in PF.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2457.surge.sh |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@glekner can you add the associated issue to the description please. |
Sorry, something went wrong.
redallen
approved these changes
Jul 5, 2019
Comment thread
...fly-3/patternfly-react/src/components/BreadcrumbSwitcher/components/BreadcrumbSearchInput.js
| inputRef={input => { | ||
| this.nameInput = input; | ||
| }} | ||
| autocomplete="off" |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Since this is just a prop passed down to the DOM in https://github.com/nkbt/react-debounce-input/blob/master/src/Component.js, this is good.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@jeff-phillips-18 can we merge? thanks! |
Sorry, something went wrong.
jeff-phillips-18
approved these changes
Jul 9, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
React requires camelCase for DOM attributes, we need to change autocomplete to autoComplete in PF.