FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(build): make pf3/pf4 build on windows by redallen · Pull Request #2471 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(build): make pf3/pf4 build on windows - #2471

Merged
dlabaj merged 4 commits into
masterfrom
fix/windows
Jul 8, 2019
ConversationCommits (4)ChecksFiles changed
Merged

fix(build): make pf3/pf4 build on windows#2471
dlabaj merged 4 commits into
masterfrom
fix/windows

Conversation

redallen commented Jul 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: A few things were necessary for Windows support.

  • Replace ' with \" in build scripts because Windows' cmd is weird.
  • Fix PF3 sass importer and remove sassIncludes because we can't rely on yarn hoisting being the same cross-platform.
  • Fix PF4 react-styles path generation to not include an incorrect full path.
  • Force hoisting react-bootstrap-typeahead, xterm, react-diff-view, and react-virtualized.
  • Fix SASS imports for pf3 storybook docs
  • Fix SASS/LESS typeahead import

Additional issues: Fixes #2469 . @timosta PatternFly should build on Windows again!! Let me know if this works for you.

TimoStaudinger commented Jul 8, 2019

Copy link
Copy Markdown

@redallen Nice! I'll try to find a minute over the next few days to give it a try and report back.

I appreciate that you guys make Windows a priority as well! :)

dlabaj previously approved these changes Jul 8, 2019
View reviewed changes
dlabaj approved these changes Jul 8, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM thanks @redallen

dlabaj merged commit 5bbc4a2 into master Jul 8, 2019

patternfly-build commented Jul 8, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@2.19.4
  • patternfly-react@2.36.4
  • @patternfly/react-console@1.11.4
  • @patternfly/react-charts@4.4.14
  • @patternfly/react-core@3.66.1
  • @patternfly/react-docs@4.8.65
  • @patternfly/react-inline-edit-extension@2.9.28
  • demo-app-ts@2.7.1
  • @patternfly/react-styled-system@3.6.11
  • @patternfly/react-styles@3.5.1
  • @patternfly/react-table@2.14.2
  • @patternfly/react-topology@2.5.9
  • @patternfly/react-virtualized-extension@1.1.61
  • @patternfly/react-icons@3.10.9

Thanks for your contribution! 🎉

redallen mentioned this pull request Jul 23, 2019
Closed
redallen deleted the fix/windows branch August 15, 2019 14:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
jeff-phillips-18 jeff-phillips-18 approved these changes
jschuler Awaiting requested review from jschuler
dgutride Awaiting requested review from dgutride

Assignees

No one assigned

Labels

Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Patternfly does not build on Windows

6 participants

Back | FazBrowse Home | New Git URL