fix(Dropdown): Provide option to not autofocus on first item - #2473
Conversation
Sorry, something went wrong.
|
PatternFly-React preview: https://patternfly-react-pr-2473.surge.sh |
Sorry, something went wrong.
TheRealJon
left a comment
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
redallen
left a comment
There was a problem hiding this comment.
I'm just nitpicking :)
Sorry, something went wrong.
| else { | ||
| (focusTarget.current.focus && focusTarget.current.focus()) || | ||
| (focusTarget && ReactDOM.findDOMNode(focusTarget.current).focus()); // eslint-disable-line react/no-find-dom-node | ||
| const { autoFocus } = this.props; |
There was a problem hiding this comment.
Could also destructure component.
Sorry, something went wrong.
|
|
||
| if (this.props.component === 'ul' && autoFocus) { | ||
| const focusTarget = | ||
| this.refsCollection.filter( |
There was a problem hiding this comment.
.find() is equivalent to .filter()[0].
Sorry, something went wrong.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
What:
Fixes Dropdown to not autofocus when custom children are given. Also provides the option to not autofocus on the first item for the case where the application wants to set autoFocus on one of the items.
Additional issues:
Fixes #2472