fix(ApplicationLauncher): Allow custom icon for application launcher toggle - #2492
Merged
jschuler merged 1 commit intoJul 10, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
redallen
approved these changes
Jul 9, 2019
redallen
suggested changes
Jul 9, 2019
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
CI failed rendering ApplicationLauncher.md:
@patternfly/react-docs: error Building static HTML failed for path "/components/applicationlauncher/" @patternfly/react-docs: See our docs page on debugging HTML builds for help https://gatsby.dev/debug-html @patternfly/react-docs: 2948 | }); @patternfly/react-docs: 2949 | // eslint-disable-next-line no-new-func @patternfly/react-docs: > 2950 | var res = new (Function.prototype.bind.apply(Function, [null].concat(['_poly', 'React'], scopeKeys, [code])))(); @patternfly/react-docs: | ^ @patternfly/react-docs: 2951 | return res.apply(undefined, [_poly, React].concat(scopeValues)); @patternfly/react-docs: 2952 | }; @patternfly/react-docs: 2953 | @patternfly/react-docs: @patternfly/react-docs: WebpackError: ReferenceError: HelpIcon is not defined @patternfly/react-docs: @patternfly/react-docs: - react-live.es.js:2950 ApplicationLauncheIcon.render @patternfly/react-docs: [project]/[react-live]/dist/react-live.es.js:2950:1
Sorry, something went wrong.
jeff-phillips-18
force-pushed
the
app-launcher
branch
from
b4a832c to
1088eed
Compare
July 9, 2019 20:32
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2492.surge.sh |
Sorry, something went wrong.
redallen
approved these changes
Jul 10, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good fix :)
Sorry, something went wrong.
jschuler
approved these changes
Jul 10, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Accept a prop (toggleIcon) to allow overriding the application launcher's toggle icon.