FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Tabs): Implement overflow styles for secondary tabs by jessiehuff · Pull Request #2512 · patternfly/patternfly-react · GitHub

feat(Tabs): Implement overflow styles for secondary tabs - #2512

Merged
redallen merged 4 commits into
patternfly:masterfrom
jessiehuff:feat/tabsOverflow
Jul 17, 2019
Merged

feat(Tabs): Implement overflow styles for secondary tabs#2512
redallen merged 4 commits into
patternfly:masterfrom
jessiehuff:feat/tabsOverflow

Conversation

Copy link
Copy Markdown
Contributor

Fixes #1705

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2512.surge.sh

tlabaj requested a review from jschuler July 12, 2019 18:20
tlabaj requested a review from mcoker July 12, 2019 18:20
redallen previously approved these changes Jul 16, 2019
mcoker previously approved these changes Jul 16, 2019

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Left a comment about sentence case, but otherwise LGTM!! Nice job @jessiehuff!!

jschuler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!

redallen merged commit d840c4d into patternfly:master Jul 17, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.73.0
  • @patternfly/react-docs@4.8.80
  • @patternfly/react-inline-edit-extension@2.9.43
  • demo-app-ts@2.12.5
  • @patternfly/react-table@2.14.17
  • @patternfly/react-topology@2.6.14
  • @patternfly/react-virtualized-extension@1.1.76

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement overflow styles for secondary tabs

6 participants


Back | FazBrowse Home | New Git URL