fix(react-table): check empty array in areAllRowsSelected - #2527
Merged
redallen merged 1 commit intoJul 22, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2527.surge.sh |
Sorry, something went wrong.
jschuler
approved these changes
Jul 17, 2019
redallen
approved these changes
Jul 22, 2019
Copy link
Copy Markdown
Contributor
|
There's probably an isArray() type deal we can use in case we get passed a weird object with a length prop that isn't an array, but this will suffice. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
If an empty array is passed for rows (along with onSelect for the "Selectable table" variation), currently the "all rows selection" checkbox in the top left will be set true b/c rows.every evaluates true with an empty array.
returns true when called.
Noted this while testing selection downstream today...
Additional issues: