FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Pagination): add disabled flag for whole component by kmcfaul · Pull Request #2586 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Pagination): add disabled flag for whole component - #2586

Merged
jschuler merged 5 commits into
patternfly:masterfrom
kmcfaul:pagination-disabled
Aug 8, 2019
ConversationCommits (5)ChecksFiles changed
Merged

feat(Pagination): add disabled flag for whole component#2586
jschuler merged 5 commits into
patternfly:masterfrom
kmcfaul:pagination-disabled

Conversation

kmcfaul commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

What: Adds 'isDisabled' flag to disable the whole pagination component.

See issue: #2315

patternfly-build commented Jul 24, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2586.surge.sh

tlabaj requested a review from christiemolloy July 25, 2019 15:25
christiemolloy reviewed Jul 25, 2019
View reviewed changes

christiemolloy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great. The options menu toggle isn't aligning correctly, looks like its only in the pagination component:

kmcfaul commented Jul 25, 2019

Copy link
Copy Markdown
Contributor Author

The options menu toggle isn't aligning correctly

Am I missing a class?

kmcfaul force-pushed the pagination-disabled branch from 0e8bb9e to 1a0f09e Compare July 26, 2019 14:03
kmcfaul force-pushed the pagination-disabled branch from 1a0f09e to 7f67e2a Compare July 31, 2019 14:04
tlabaj suggested changes Aug 1, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking good. Can you update the demo app and the integration test please

karelhala previously approved these changes Aug 6, 2019
View reviewed changes
kmcfaul force-pushed the pagination-disabled branch from b079f62 to 44bec10 Compare August 6, 2019 18:29
mcoker previously approved these changes Aug 7, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

tlabaj previously approved these changes Aug 7, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler reviewed Aug 7, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Pagination/OptionsToggle.tsx Outdated
}:OptionsToggleProps ) => {
return (
<div className={css(styles.optionsMenuToggle, getModifier(styles, 'plain'), getModifier(styles, 'text'))} >
<div className={css(styles.optionsMenuToggle, isDisabled && getModifier(styles, 'disabled'), getModifier(styles, 'plain'), getModifier(styles, 'text'))} >

jschuler Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: it generally makes more sense to use getModifier if a variable prop can be matched to the style object. In this case i would change these to styles.disabled, styles.plain, etc..

kmcfaul Aug 8, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah I thought that was just how we retrieved modifier styles. I can change it to styles.modifiers.disabled and so on.

jschuler reviewed Aug 7, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Pagination/Pagination.md Outdated
import React from 'react';
import { Pagination, PaginationVariant } from '@patternfly/react-core';

class PaginationTop extends React.Component {

jschuler Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: class name should be PaginationDisabled. Doesn't affect the rendering but shows up in the sample code

kmcfaul dismissed stale reviews from tlabaj and mcoker via 0e217f3 August 8, 2019 15:24
tlabaj approved these changes Aug 8, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler merged commit 7683f68 into patternfly:master Aug 8, 2019

patternfly-build commented Aug 8, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-console@1.12.0
  • @patternfly/react-core@3.84.0
  • @patternfly/react-docs@4.9.26
  • @patternfly/react-inline-edit-extension@2.9.71
  • demo-app-ts@2.17.0
  • @patternfly/react-integration@2.17.0
  • @patternfly/react-table@2.16.10
  • @patternfly/react-topology@2.7.19
  • @patternfly/react-virtualized-extension@1.1.105

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker left review comments
+4 more reviewers
christiemolloy christiemolloy left review comments
jschuler jschuler approved these changes
tlabaj tlabaj approved these changes
karelhala karelhala left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

dlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL