fix(select): add isPlain variation/prop to Select.tsx, snapshot tests, and integration - #2588
Merged
redallen merged 5 commits intoJul 31, 2019
Merged
fix(select): add isPlain variation/prop to Select.tsx, snapshot tests, and integration#2588redallen merged 5 commits into
redallen merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2588.surge.sh |
Sorry, something went wrong.
tlabaj
previously requested changes
Jul 25, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looking good. I would update the demo as well. It is good practice to verify that the props work in integration.
Sorry, something went wrong.
redallen
approved these changes
Jul 30, 2019
kmcfaul
approved these changes
Jul 31, 2019
mcoker
reviewed
Jul 31, 2019
mcoker
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
👍
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #2371.