feat(Select): adds direction prop to Select - #2611
Merged
redallen merged 4 commits intoAug 19, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2611.surge.sh |
Sorry, something went wrong.
tlabaj
previously requested changes
Aug 7, 2019
tlabaj
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I would also add this ti the integration app to verify prop works with no errors.
Sorry, something went wrong.
kmcfaul
force-pushed
the
select-direction
branch
from
84891e8 to
da4f320
Compare
August 19, 2019 14:03
redallen
suggested changes
Aug 19, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
packages/patternfly-4/react-core/src/components/Select/Select.tsx
Outdated
jschuler
suggested changes
Aug 19, 2019
jschuler
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Since we have the enum we should use it consistently :)
Sorry, something went wrong.
Comment thread
packages/patternfly-4/react-core/src/components/Select/Select.md
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Select/Select.md
Outdated
Comment thread
packages/patternfly-4/react-core/src/components/Select/Select.md
Outdated
Comment thread
...es/patternfly-4/react-integration/demo-app-ts/src/components/demos/SelectDemo/SelectDemo.tsx
Outdated
Comment thread
...es/patternfly-4/react-integration/demo-app-ts/src/components/demos/SelectDemo/SelectDemo.tsx
Outdated
Comment thread
...es/patternfly-4/react-integration/demo-app-ts/src/components/demos/SelectDemo/SelectDemo.tsx
Outdated
jschuler
approved these changes
Aug 19, 2019
redallen
approved these changes
Aug 19, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Allows user to specify the direction of the Select's menu expansion. Adds a SelectDirection enum for explicit directions.
Refer to issue: #2368