FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(table): replace lodash-es with lodash by redallen · Pull Request #2641 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(table): replace lodash-es with lodash - #2641

Merged
jschuler merged 1 commit into
patternfly:masterfrom
redallen:chore/replace-lodash-es
Aug 5, 2019
ConversationCommits (1)ChecksFiles changed
Merged

chore(table): replace lodash-es with lodash#2641
jschuler merged 1 commit into
patternfly:masterfrom
redallen:chore/replace-lodash-es

Conversation

redallen commented Aug 5, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What: Fixes #2617 Fixes #2616

Additional issues:

redallen requested a review from priley86 August 5, 2019 15:28
priley86 reviewed Aug 5, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-virtualized-extension/package.json
},
"peerDependencies": {
"@patternfly/react-table": "^2.10.0",
"lodash-es": "4.x",

priley86 Aug 5, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should lodash be added as a peerDependency now?

redallen Aug 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

react-virtualized-extension doesn't use lodash-es anywhere.

patternfly-build commented Aug 5, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2641.surge.sh

redallen mentioned this pull request Aug 5, 2019
Closed

priley86 commented Aug 5, 2019

Copy link
Copy Markdown
Member

this is nearly identical to #2640 now... let's pick one 😄

aljesusg commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

This Fix #2616 too.

jschuler merged commit ad3ccc8 into patternfly:master Aug 5, 2019

aljesusg commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

Hooray !!! Thanks

patternfly-build commented Aug 5, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-docs@4.9.18
  • @patternfly/react-inline-edit-extension@2.9.64
  • @patternfly/react-table@2.16.4
  • @patternfly/react-virtualized-extension@1.1.97

Thanks for your contribution! 🎉

aljesusg mentioned this pull request Aug 5, 2019
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jschuler jschuler approved these changes
priley86 priley86 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace lodash-es with lodash [PF4] lodash-es problems in React-table

5 participants

Back | FazBrowse Home | New Git URL