FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(loginForm): adds autoFocus to username input by jenny-s51 · Pull Request #2659 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(loginForm): adds autoFocus to username input #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redallen merged 3 commits into from
Aug 21, 2019
Conversation 4 Commits 3 Checks 0 Files changed
Merged

fix(loginForm): adds autoFocus to username input #2659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58a897a
fix(loginForm): adds autoFocus to username input
jenny-s51 Aug 7, 2019
d545106
adding updated snapshot test
jenny-s51 Aug 7, 2019
82a79bc
fix(loginForm): add noAutoFocus prop
jenny-s51 Aug 21, 2019
File filter

Filter by extension

Filter by extension .snap  (1) .tsx  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
    • LoginForm.tsx
5 changes: 4 additions & 1 deletion packages/patternfly-4/react-core/src/components/LoginPage/LoginForm.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { Button } from '../Button';
import { Checkbox } from '../Checkbox';

export interface LoginFormProps extends React.HTMLProps<HTMLFormElement> {
/** Flag to indicate if the first dropdown item should not gain initial focus */
noAutoFocus?: boolean,
/** Additional classes added to the Login Main Body's Form */
className?: string;
/** Flag indicating the Helper Text is visible * */
Expand Down Expand Up @@ -46,6 +48,7 @@ export interface LoginFormProps extends React.HTMLProps<HTMLFormElement> {
}

export const LoginForm: React.FunctionComponent<LoginFormProps> = ({
noAutoFocus = false,
className = '',
showHelperText = false,
helperText = null,
Expand All @@ -71,7 +74,7 @@ export const LoginForm: React.FunctionComponent<LoginFormProps> = ({
{helperText}
</FormHelperText>
<FormGroup label={usernameLabel} isRequired isValid={isValidUsername} fieldId="pf-login-username-id">
<TextInput
<TextInput autoFocus={!noAutoFocus}
id="pf-login-username-id"
isRequired
isValid={isValidUsername}
Expand Down
3 changes: 3 additions & 0 deletions ...es/patternfly-4/react-core/src/components/LoginPage/__snapshots__/LoginForm.test.tsx.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ exports[`LoginForm with rememberMeLabel 1`] = `
>
<TextInput
aria-label={null}
autoFocus={true}
className=""
id="pf-login-username-id"
isDisabled={false}
Expand Down Expand Up @@ -92,6 +93,7 @@ exports[`LoginForm with rememberMeLabel and rememberMeAriaLabel uses the remembe
>
<TextInput
aria-label={null}
autoFocus={true}
className=""
id="pf-login-username-id"
isDisabled={false}
Expand Down Expand Up @@ -168,6 +170,7 @@ exports[`should render Login form 1`] = `
>
<TextInput
aria-label={null}
autoFocus={true}
className=""
id="pf-login-username-id"
isDisabled={false}
Expand Down
Back | FazBrowse Home | New Git URL