refactor(Page): Change the defaultManagedSidebarOpen prop name for co… - #2664
Merged
jschuler merged 1 commit intoAug 8, 2019
Merged
refactor(Page): Change the defaultManagedSidebarOpen prop name for co…#2664jschuler merged 1 commit into
jschuler merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2664.surge.sh |
Sorry, something went wrong.
jenny-s51
self-requested a review
August 8, 2019 13:15
jenny-s51
approved these changes
Aug 8, 2019
jenny-s51
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM 🙂
Sorry, something went wrong.
jschuler
approved these changes
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nsistency
#2662
What: Since we are prerelease we are changing the prop name to be consistent with other components that have a similar prop for default behaviour.
Additional issues: