FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Table): add new visibleOn and hiddenOn breakpoint by kmcfaul · Pull Request #2676 · patternfly/patternfly-react · GitHub

feat(Table): add new visibleOn and hiddenOn breakpoint - #2676

Merged
jschuler merged 2 commits into
patternfly:masterfrom
kmcfaul:table-2xl-breakpoint
Aug 19, 2019
Merged

feat(Table): add new visibleOn and hiddenOn breakpoint#2676
jschuler merged 2 commits into
patternfly:masterfrom
kmcfaul:table-2xl-breakpoint

Conversation

kmcfaul commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

What: Adds the new 2xl breakpoint to visibleOn and hiddenOn classes.

Refer to issue: #2436

@priley86 Is there a good way to add tests for this? I'm unfamiliar with table and unsure how it uses the Visibility object.

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2676.surge.sh

Copy link
Copy Markdown
Member

this looks good to me @kmcfaul. I believe it would be great to add unit tests in Table.tests.tsx for this after #2360 lands. We can add some new tests for columnTransforms there I'm guessing.

kmcfaul force-pushed the table-2xl-breakpoint branch from 6d7497a to 5055e13 Compare August 19, 2019 13:41
jschuler merged commit 701461f into patternfly:master Aug 19, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-inline-edit-extension@2.10.6
  • @patternfly/react-table@2.18.0

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL