FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Select): add disabled flag for component by kmcfaul · Pull Request #2678 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Select): add disabled flag for component - #2678

Merged
jschuler merged 4 commits into
patternfly:masterfrom
kmcfaul:select-disabled
Aug 9, 2019
ConversationCommits (4)ChecksFiles changed
Merged

feat(Select): add disabled flag for component#2678
jschuler merged 4 commits into
patternfly:masterfrom
kmcfaul:select-disabled

Conversation

kmcfaul commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

What: Adds isDisabled flag to select.

Refer to issue: #2366

kmcfaul commented Aug 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Requires core to be updated to v2.26 to get styling, in #2668

patternfly-build commented Aug 9, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2678.surge.sh

tlabaj suggested changes Aug 9, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

just a typo to fix

mcoker previously approved these changes Aug 9, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

great job @kmcfaul! 🥇

tlabaj previously approved these changes Aug 9, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler reviewed Aug 9, 2019
View reviewed changes
Comment thread packages/patternfly-4/react-core/src/components/Select/Select.md Outdated
constructor(props) {
super(props);
this.options = [
{ value: 'Alabama', disabled: false },

jschuler Aug 9, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd remove the disabled keys from the options array in the two added examples for clarity purposes

tlabaj Aug 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was thinking they same thing. But thought it was fine. You are right though, it would be more clear.

jessiehuff previously approved these changes Aug 9, 2019
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! :)

jschuler reviewed Aug 9, 2019
View reviewed changes

jschuler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about instead of adding more examples just to demonstrate this, add a checkbox to an existing example that can toggle isDisabled?

tlabaj added PF4 labels Aug 9, 2019

tlabaj commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

@jschuler , I think the examples are fine as is. They match core.

kmcfaul dismissed stale reviews from jessiehuff and tlabaj via 5d8e002 August 9, 2019 20:45
tlabaj approved these changes Aug 9, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jschuler merged commit a72124f into patternfly:master Aug 9, 2019
tlabaj mentioned this pull request Aug 9, 2019
Closed

patternfly-build commented Aug 9, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.86.0
  • @patternfly/react-docs@4.10.2
  • @patternfly/react-inline-edit-extension@2.9.75
  • demo-app-ts@2.19.0
  • @patternfly/react-integration@2.19.0
  • @patternfly/react-table@2.16.14
  • @patternfly/react-topology@2.7.23
  • @patternfly/react-virtualized-extension@1.1.109

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcoker mcoker left review comments
+3 more reviewers
jschuler jschuler approved these changes
tlabaj tlabaj approved these changes
jessiehuff jessiehuff left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

jschuler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL