FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(button): set the disable modifier when component is not button by boaz0 · Pull Request #2683 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(button): set the disable modifier when component is not button - #2683

Merged
dlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_2666
Sep 19, 2019
ConversationCommits (1)ChecksFiles changed
Merged

fix(button): set the disable modifier when component is not button#2683
dlabaj merged 1 commit into
patternfly:masterfrom
boaz0:closes_2666

Conversation

boaz0 commented Aug 12, 2019

Copy link
Copy Markdown
Member

What:

closes #2666

If component is not button and isDisabled is true then add pf-m-disabled to class name.

//cc @mcoker

patternfly-build commented Aug 12, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2683.surge.sh

tlabaj requested review from kmcfaul and mcoker August 12, 2019 19:58
mcoker reviewed Aug 12, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Not sure if this is outside of the scope of this PR, but this is also a problem in the select, dropdown, and options menu. Should we fix those in this PR or is that a separate issue?

kmcfaul previously approved these changes Aug 29, 2019
View reviewed changes
fix(button): set the disable modifier when component is not button
2c7ac27 
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>

boaz0 commented Sep 16, 2019

Copy link
Copy Markdown
Member Author

fixed merge conflicts

tlabaj commented Sep 16, 2019 •
edited by mcoker
Loading

Copy link
Copy Markdown
Contributor

@mcoker I can open up a follow up issue. Just to clarify, For the Select, the <div> containing the <button> should not have the pf-m-disabled modifier applied correct?

tlabaj commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Issue #2937 has n=been opened to address the issue with the dropdown

tlabaj approved these changes Sep 16, 2019
View reviewed changes

tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcoker commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

@tlabaj Yeah, basically the toggle can either be a <div> or a <button>. When the toggle is a <button>, we should use the disabled attribute to disable it. If the toggle is a <div>, we should use .pf-m-disabled to disable it.

mcoker approved these changes Sep 16, 2019
View reviewed changes

mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

excellent!

dlabaj approved these changes Sep 19, 2019
View reviewed changes

dlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

dlabaj merged commit 39b359d into patternfly:master Sep 19, 2019

patternfly-build commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.104.8
  • @patternfly/react-docs@4.13.10
  • @patternfly/react-inline-edit-extension@2.11.44
  • demo-app-ts@3.0.7
  • @patternfly/react-table@2.20.24
  • @patternfly/react-topology@2.8.42
  • @patternfly/react-virtualized-extension@1.2.32

Thanks for your contribution! 🎉

boaz0 deleted the closes_2666 branch April 24, 2020 06:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj dlabaj approved these changes
mcoker mcoker approved these changes
kmcfaul kmcfaul left review comments
+1 more reviewer
tlabaj tlabaj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

kmcfaul

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

disabled button should only apply the disabled attribute

6 participants

Back | FazBrowse Home | New Git URL