FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(radio): group radio inputs in docs (axe-core) by boaz0 · Pull Request #2684 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

fix(radio): group radio inputs in docs (axe-core) #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessiehuff merged 1 commit into from
Oct 3, 2019
Conversation 37 Commits 1 Checks 0 Files changed
Merged

fix(radio): group radio inputs in docs (axe-core) #2684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .md  (1) .snap  (1) .tsx  (2) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
    • Radio.md
    • Radio.test.tsx
    • Radio.tsx
      • Radio.test.tsx.snap
57 changes: 38 additions & 19 deletions packages/patternfly-4/react-core/src/components/Radio/Radio.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ propComponents: ['Radio']
import { Radio } from '@patternfly/react-core';

## Controlled radio

```js
import React from 'react';
import { Radio } from '@patternfly/react-core';
Expand All @@ -16,33 +17,24 @@ class ControlledRadio extends React.Component {
constructor(props) {
super(props);
this.state = {
value: '4'
check1: false,
};

this.handleChange = (_, event) => {
const { value } = event.currentTarget;
this.setState({ value });
this.setState({ [value]: true });
};
}

render() {
return (
<React.Fragment>
<Radio
value="3"
isChecked={this.state.value === '3'}
name="pf-version"
onChange={this.handleChange}
label="Controlled radio 1"
id="radio-1"
/>{' '}
<Radio
value="4"
isChecked={this.state.value === '4'}
name="pf-version"
isChecked={this.state.check1}
name="radio-1"
onChange={this.handleChange}
label="Controlled radio 2"
id="radio-2"
label="Controlled radio"
id="radio-controlled"
/>
</React.Fragment>
);
Expand All @@ -51,27 +43,54 @@ class ControlledRadio extends React.Component {
```

## Uncontrolled radio

```js
import React from 'react';
import { Radio } from '@patternfly/react-core';

UncontrolledRadio = () => (
<React.Fragment>
<Radio label="Uncontrolled radio example" id="radio-4" name="radio-4" />
<Radio label="Uncontrolled radio example" id="radio-5" name="radio-4" />
<Radio label="Uncontrolled radio example" id="radio-uncontrolled" name="radio-2" />
</React.Fragment>
);
```

## Reversed radio

```js
import React from 'react';
import { Radio } from '@patternfly/react-core';

ReversedRadio = () => (
<React.Fragment>
<Radio isLabelBeforeButton label="Reversed radio example" id="radio-reversed" name="radio-3" />
</React.Fragment>
);
```

## Label wraps input radio

```js
import React from 'react';
import { Radio } from '@patternfly/react-core';

LabelWrapsInputRadio = () => (
<React.Fragment>
<Radio isLabelWrapped label="Label wraps input example" id="radio-label-wraps-input" name="radio-4" />
</React.Fragment>
);
```

## Disabled radio

```js
import React from 'react';
import { Radio } from '@patternfly/react-core';

DisabledRadio = () => (
<React.Fragment>
<Radio label="Disabled checked radio example" defaultChecked isDisabled name="group-1" id="radio-disabled" />{' '}
<Radio id="radio-disabled-2" label="Disabled radio example" isDisabled name="group-2" />
<Radio id="radio-disabled" label="Disabled radio example" isDisabled name="radio-5" />
<Radio id="radio-disabled-checked" defaultChecked label="Disabled and checked radio example" isDisabled name="radio-6" />
</React.Fragment>
);
```
10 changes: 10 additions & 0 deletions packages/patternfly-4/react-core/src/components/Radio/Radio.test.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,16 @@ describe('Radio check component', () => {
expect(view).toMatchSnapshot();
});

test('isLabelBeforeButton', () => {
const view = shallow(<Radio id="check" isLabelBeforeButton label="Radio label" aria-label="check" name="check" />);
expect(view).toMatchSnapshot();
});

test('isLabelWrapped', () => {
const view = shallow(<Radio id="check" isLabelWrapped label="Radio label" aria-label="check" name="check" />);
expect(view).toMatchSnapshot();
});

test('label is string', () => {
const view = shallow(<Radio label="Label" id="check" isChecked aria-label="check" name="check" />);
expect(view).toMatchSnapshot();
Expand Down
70 changes: 48 additions & 22 deletions packages/patternfly-4/react-core/src/components/Radio/Radio.tsx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ export interface RadioProps
className?: string;
/** Id of the radio. */
id: string;
/** Flag to show if the radio label is wrapped on small screen. */
isLabelWrapped?: boolean;
/** Flag to show if the radio label is shown before the radio button. */
isLabelBeforeButton?: boolean;
/** Flag to show if the radio is checked. */
isChecked?: boolean;
/** Flag to show if the radio is disabled. */
Expand Down Expand Up @@ -51,35 +55,57 @@ export class Radio extends React.Component<RadioProps> {
checked,
className,
defaultChecked,
isLabelWrapped,
isLabelBeforeButton,
isChecked,
isDisabled,
isValid,
label,
onChange,
...props
} = this.props;
return (
<div className={css(styles.radio, className)}>
<input
{...props}
className={css(styles.radioInput)}
type="radio"
onChange={this.handleChange}
aria-invalid={!isValid}
disabled={isDisabled}
defaultChecked={checked || isChecked}
{...(!isChecked && { defaultChecked })}
{...(!label && { 'aria-label': ariaLabel })}
/>
{label && (
<label
className={css(styles.radioLabel, getModifier(styles, isDisabled && ('disabled' as any)))}
htmlFor={props.id}
>
{label}
</label>
)}
</div>

const inputRendered = (
<input
{...props}
className={css(styles.radioInput)}
type="radio"
onChange={this.handleChange}
aria-invalid={!isValid}
disabled={isDisabled}
defaultChecked={checked || isChecked}
{...(!isChecked && { defaultChecked })}
{...(!label && { 'aria-label': ariaLabel })}
/>
);
const labelRendered = !label ? null : isLabelWrapped ? (
<span className={css(styles.radioLabel, getModifier(styles, isDisabled && ('disabled' as any)))}>{label}</span>
) : (
<label
className={css(styles.radioLabel, getModifier(styles, isDisabled && ('disabled' as any)))}
htmlFor={props.id}
>
{label}
</label>
);
const childrenRendered = isLabelBeforeButton ? (
<>
{labelRendered}
{inputRendered}
</>
) : (
<>
{inputRendered}
{labelRendered}
</>
);

return isLabelWrapped ? (
<label className={css(styles.radio, className)} htmlFor={props.id}>
{childrenRendered}
</label>
) : (
<div className={css(styles.radio, className)}>{childrenRendered}</div>
);
}
}
44 changes: 44 additions & 0 deletions packages/patternfly-4/react-core/src/components/Radio/__snapshots__/Radio.test.tsx.snap
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,50 @@ exports[`Radio check component isDisabled 1`] = `
</div>
`;

exports[`Radio check component isLabelBeforeButton 1`] = `
<div
className="pf-c-radio"
>
<label
className="pf-c-radio__label"
htmlFor="check"
>
Radio label
</label>
<input
aria-invalid={false}
className="pf-c-radio__input"
disabled={false}
id="check"
name="check"
onChange={[Function]}
type="radio"
/>
</div>
`;

exports[`Radio check component isLabelWrapped 1`] = `
<label
className="pf-c-radio"
htmlFor="check"
>
<input
aria-invalid={false}
className="pf-c-radio__input"
disabled={false}
id="check"
name="check"
onChange={[Function]}
type="radio"
/>
<span
className="pf-c-radio__label"
>
Radio label
</span>
</label>
`;

exports[`Radio check component label is function 1`] = `
<div
className="pf-c-radio"
Expand Down
Back | FazBrowse Home | New Git URL