feat(Icons - config): Publish configs as well with icons - #2701
Merged
jschuler merged 1 commit intoAug 23, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2701.surge.sh |
Sorry, something went wrong.
redallen
approved these changes
Aug 14, 2019
Comment thread
packages/react-icons/build/templates/iconFile.hbs
| }; | ||
|
|
||
| export default {{name}}; | ||
| export default createIcon({{name}}Config); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I like this approach.
Sorry, something went wrong.
jschuler
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Some usecases require the original SVG path to be used instead of React component (for instance when using icons in svg). So this PR will introduce iconConfig (for each icon) alongSide the exported icon.
Additional issues: