feat(charts): add bullet chart - #2708
Merged
redallen merged 2 commits intoAug 19, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2708.surge.sh/patternfly-4/charts/chartbullet/ |
Sorry, something went wrong.
redallen
previously approved these changes
Aug 15, 2019
dlabrecq
force-pushed
the
1600-bullet-chart
branch
from
07814fc to
aa12925
Compare
August 15, 2019 17:46
redallen
previously approved these changes
Aug 15, 2019
dlabrecq
force-pushed
the
1600-bullet-chart
branch
from
aa12925 to
ca6ffb3
Compare
August 15, 2019 18:04
mceledonia
previously approved these changes
Aug 15, 2019
mceledonia
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks good to me, thanks Dan.
Sorry, something went wrong.
redallen
previously approved these changes
Aug 15, 2019
dlabrecq
force-pushed
the
1600-bullet-chart
branch
6 times, most recently
from
dff869f to
e5afccd
Compare
August 19, 2019 14:51
This was referenced Aug 19, 2019
dlabrecq
force-pushed
the
1600-bullet-chart
branch
from
e5afccd to
cb7fc0b
Compare
August 19, 2019 18:33
kmcfaul
previously approved these changes
Aug 19, 2019
dlabrecq
dismissed stale reviews from kmcfaul, redallen, and mceledonia
via
08f5576
August 19, 2019 19:29
dlabrecq
force-pushed
the
1600-bullet-chart
branch
from
cb7fc0b to
08f5576
Compare
August 19, 2019 19:29
mceledonia
approved these changes
Aug 19, 2019
redallen
approved these changes
Aug 19, 2019
redallen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🎖
Sorry, something went wrong.
kmcfaul
approved these changes
Aug 19, 2019
Copy link
Copy Markdown
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the bullet chart component.
Note that new theme variables will be added to PatternFly core via a separate PR.
Worked from @mceledonia 's color mock, using the latest PF color scales:
https://docs.google.com/document/d/1cw10pJFXWruB1SA8TQwituxn5Ss6KpxYPCOYGrH8qAY/edit
And included features from the existing design on pf.org:
See https://www.patternfly.org/v3/pattern-library/data-visualization/bullet-chart/#design
Fixes #1600
There are various examples available via the demo, but here are a few snapshots: