FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(textarea): handle uncontrolled default value by redallen · Pull Request #2712 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

chore(textarea): handle uncontrolled default value - #2712

Merged
TheRealJon merged 1 commit into
patternfly:masterfrom
redallen:chore/textarea-error
Aug 29, 2019
ConversationCommits (1)ChecksFiles changed
Merged

chore(textarea): handle uncontrolled default value#2712
TheRealJon merged 1 commit into
patternfly:masterfrom
redallen:chore/textarea-error

Conversation

redallen commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

What: Fixes #2705

Additional issues:

patternfly-build commented Aug 15, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2712.surge.sh

boaz0 approved these changes Aug 16, 2019
View reviewed changes

boaz0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

redallen requested a review from jenny-s51 August 19, 2019 18:54
jenny-s51 approved these changes Aug 22, 2019
View reviewed changes

jenny-s51 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking good! 👍 Just so you know, @seanforyou23 has a similar PR up for this at #2698, but since yours is the one with a demo, I think Michael's can be closed

redallen mentioned this pull request Aug 27, 2019
Closed
jessiehuff approved these changes Aug 27, 2019
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

TheRealJon reviewed Aug 29, 2019
View reviewed changes

TheRealJon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

/lgtm

TheRealJon merged commit b0524b8 into patternfly:master Aug 29, 2019

patternfly-build commented Aug 29, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-core@3.94.2
  • @patternfly/react-docs@4.10.33
  • @patternfly/react-inline-edit-extension@2.11.8
  • demo-app-ts@2.21.12
  • @patternfly/react-table@2.19.8
  • @patternfly/react-topology@2.8.8
  • @patternfly/react-virtualized-extension@1.1.139

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tlabaj Awaiting requested review from tlabaj
dlabaj Awaiting requested review from dlabaj
jschuler Awaiting requested review from jschuler
kmcfaul Awaiting requested review from kmcfaul
4 more reviewers
TheRealJon TheRealJon left review comments
boaz0 boaz0 approved these changes
jessiehuff jessiehuff approved these changes
jenny-s51 jenny-s51 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

tlabaj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TextArea throws warning when being used as an uncontrolled component

7 participants

Back | FazBrowse Home | New Git URL