feat(PF4 - Drawer): Update drawer to expose all parts - #2733
Conversation
Sorry, something went wrong.
|
PatternFly-React preview: https://patternfly-react-pr-2733.surge.sh |
Sorry, something went wrong.
redallen
left a comment
There was a problem hiding this comment.
This mirrors components like Card and Accordion better.
Sorry, something went wrong.
| /** Indicates if the content element and panel element are displayed side by side. */ | ||
| isInline?: boolean; | ||
| /** Content rendered in the drawer */ | ||
| panelContent?: React.ReactNode; |
There was a problem hiding this comment.
Experimental 🎉
Sorry, something went wrong.
There was a problem hiding this comment.
Exactly! Good way we added it in experimental so we can improve the API before it's full fledged component.
Sorry, something went wrong.
| className="pf-c-drawer__content" | ||
| > | ||
|
|
||
| <Component> |
There was a problem hiding this comment.
Should change test to use mount instead of shallow so we can get more info here
Sorry, something went wrong.
There was a problem hiding this comment.
Sure thing!
Sorry, something went wrong.
redallen
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
kmcfaul
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
dlabaj
left a comment
There was a problem hiding this comment.
Thanks @karelhala I like this better then the original. Thanks for making the updates.
Sorry, something went wrong.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
What:
Thank you @dlabaj for experimental Drawer component! Usage is nice and straight forward, what do you think about exposing DrawerContent as well? This way users can add the DrawerPanelContent when they want to, for instance when data in it should be loaded from server so they want to show it only when user clicks on some element to show it. Also special classes and attributes can be aplied to Content so for instance if app has some special attributes to track where user is located they can do that easilly with this.
It's essentially the same, except that content is not part of Drawer itself, but special component and Panel is not sent trough prop but as child.