FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(Ansible icon): Add ansible tower icon to custom icons definition by karelhala · Pull Request #2735 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(Ansible icon): Add ansible tower icon to custom icons definition - #2735

Merged
redallen merged 1 commit into
patternfly:masterfrom
karelhala:ansible-icon
Aug 20, 2019
ConversationCommits (1)ChecksFiles changed
Merged

feat(Ansible icon): Add ansible tower icon to custom icons definition#2735
redallen merged 1 commit into
patternfly:masterfrom
karelhala:ansible-icon

Conversation

karelhala commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

What:
Since Ansible Tower is RH product, let's add it's icon to our icon drawer as well so app devs can include it in their apps.

Additional issues:

patternfly-build commented Aug 20, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2735.surge.sh

AllenBW commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

This is SO long over due. 🥰🥰🥰🥰

AllenBW approved these changes Aug 20, 2019
View reviewed changes

AllenBW left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🤤🤤🤤🤓🤓🤓🥳🥳🥳

redallen approved these changes Aug 20, 2019
View reviewed changes

redallen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pretty.

boaz0 approved these changes Aug 20, 2019
View reviewed changes

boaz0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

jessiehuff approved these changes Aug 20, 2019
View reviewed changes

jessiehuff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! :)

redallen merged commit 0ffe527 into patternfly:master Aug 20, 2019

patternfly-build commented Aug 20, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@4.8.1
  • @patternfly/react-core@3.89.2
  • @patternfly/react-docs@4.10.18
  • @patternfly/react-inline-edit-extension@2.10.14
  • demo-app-ts@2.20.6
  • @patternfly/react-table@2.18.8
  • @patternfly/react-topology@2.7.39
  • @patternfly/react-virtualized-extension@1.1.125
  • @patternfly/react-icons@3.11.0

Thanks for your contribution! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dlabaj Awaiting requested review from dlabaj
tlabaj Awaiting requested review from tlabaj
jschuler Awaiting requested review from jschuler
4 more reviewers
boaz0 boaz0 approved these changes
AllenBW AllenBW approved these changes
jessiehuff jessiehuff approved these changes
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL