FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adjust legend position for axis label by dlabrecq · Pull Request #2763 · patternfly/patternfly-react · GitHub

Adjust legend position for axis label - #2763

Merged
dlabrecq merged 1 commit into
patternfly:masterfrom
dlabrecq:2762-axis-label-legend
Aug 26, 2019
Merged

Adjust legend position for axis label#2763
dlabrecq merged 1 commit into
patternfly:masterfrom
dlabrecq:2762-axis-label-legend

Conversation

dlabrecq commented Aug 22, 2019
edited
Loading

Copy link
Copy Markdown
Member

In Cost Management, we want to use the chart's embedded legend, but also with an axis label. Currently, the legend and axis label occupy the same vertical position. This change simply adjusts the legend if an axis label is in use.

Fixes #2762

dlabrecq changed the title fix(charts): adjust legend position for axis label Adjust legend position for axis label Aug 22, 2019
dlabrecq requested a review from redallen August 22, 2019 20:35

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2763.surge.sh

dlabrecq force-pushed the 2762-axis-label-legend branch from d817def to 2235943 Compare August 25, 2019 15:45
dlabrecq merged commit 6a93c7c into patternfly:master Aug 26, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • @patternfly/react-charts@4.8.4

Thanks for your contribution! 🎉

dlabrecq deleted the 2762-axis-label-legend branch September 25, 2019 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust chart legend position for axis label

5 participants


Back | FazBrowse Home | New Git URL