fix(tooltip): allow manual trigger, access to tippy.js props - #2769
Conversation
Sorry, something went wrong.
|
PatternFly-React preview: https://patternfly-react-pr-2769.surge.sh |
Sorry, something went wrong.
| /** z-index of the tooltip */ | ||
| zIndex?: number; | ||
| /** additional Props to pass through to tippy.js */ | ||
| tippyProps?: TippyProps; |
There was a problem hiding this comment.
i think we should just add what we need in terms of props instead of a passthrough? otherwise could be more maintenance if some tippy props don't behave as expected in our component
Sorry, something went wrong.
There was a problem hiding this comment.
I think it's better to allow the full set to be passed thru. How can we know up front which props consumers want to customize? Limiting the options will cause limits to its adoptability. If there are any issues with using a particular prop, then an issue can be raised.
Sorry, something went wrong.
There was a problem hiding this comment.
what about the fact that there'll be duplicate props, for example we expose enableFlip which would be the same as tippyProps.flip
Sorry, something went wrong.
There was a problem hiding this comment.
whatever props we accept/set will override what is in the tippyProps
Sorry, something went wrong.
There was a problem hiding this comment.
okay let's go with this, can you also add the passthrough to the Popover component as well then? Thanks
Sorry, something went wrong.
|
@jschuler @dtaylor113 Added passthru props to the Popover component as well. |
Sorry, something went wrong.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sorry, something went wrong.
What:
Allows passing properties through to PopoverBase and hence tippy.js
Adds the manual trigger option with the isVisible prop.