FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(catalog-tile): custom icon jsx for react-extensions CatalogTile by priley86 · Pull Request #2771 · patternfly/patternfly-react · GitHub

/ patternfly-react Public

feat(catalog-tile): custom icon jsx for react-extensions CatalogTile - #2771

Merged
redallen merged 1 commit into
patternfly:masterfrom
priley86:catalog-tile-icon
Aug 27, 2019
ConversationCommits (1)ChecksFiles changed
Merged

feat(catalog-tile): custom icon jsx for react-extensions CatalogTile#2771
redallen merged 1 commit into
patternfly:masterfrom
priley86:catalog-tile-icon

Conversation

priley86 commented Aug 23, 2019

Copy link
Copy Markdown
Member

What:
Closes #2770

cc: @jeff-phillips-18 @christianvogt

Additional issues:

christianvogt commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

@priley86 the other icon options apply catalog-tile-pf-icon. The size is no longer controlled if supplying a component as an icon. Is this intended? Do you expect the dev to explicitly supply an catalog-tile-pf-icon or equivalent?

patternfly-build commented Aug 23, 2019

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://patternfly-react-pr-2771.surge.sh

jeff-phillips-18 commented Aug 23, 2019

Copy link
Copy Markdown
Member

@priley86 @christianvogt I think wrapping the provided icon component in a span with the catalog-tile-pf-icon class would work to keep the icon the correct size.

priley86 commented Aug 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

actually... will not work... we have to have a way to prevent icon from rendering too I assume. Will tweak once more.
ok, i think this should do it.

PTAL @jeff-phillips-18 @christianvogt

redallen merged commit 694cd04 into patternfly:master Aug 27, 2019

patternfly-build commented Aug 27, 2019

Copy link
Copy Markdown
Collaborator

Your changes have been released in:

  • patternfly-react-extensions@2.20.0

Thanks for your contribution! 🎉

dgutride mentioned this pull request Aug 27, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jeff-phillips-18 jeff-phillips-18 approved these changes
+1 more reviewer
redallen redallen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Catalog Tile - custom icon

5 participants

Back | FazBrowse Home | New Git URL