Improve linting - #2787
Conversation
Sorry, something went wrong.
|
PatternFly-React preview: https://patternfly-react-pr-2787.surge.sh |
Sorry, something went wrong.
mturley
left a comment
There was a problem hiding this comment.
Mostly this looks good, but there's still some weird indentation going on. I'll take a look at the config and come back to it. We can go ahead and merge now if you want, if so I'll address the indentation in another PR.
Sorry, something went wrong.
| position: DropdownPosition.left, | ||
| onSelect: (_event: any): any => undefined, | ||
| onToggle: (_value: boolean): any => undefined, | ||
| "className": '', |
There was a problem hiding this comment.
This is a bit weird, what rule added quotes to all of these defaultProps? I wonder why it didn't do the same to all the others?
Sorry, something went wrong.
| isRead = false, | ||
| className = '', | ||
| children = '', | ||
| ...props }: BadgeProps) => ( |
There was a problem hiding this comment.
There's still some weird spacing going on here.
Sorry, something went wrong.
| export interface CardHeaderProps extends React.HTMLProps<HTMLDivElement> { | ||
| /** Content rendered inside the Card Footer */ | ||
| children?: React.ReactNode; | ||
| children?: React.ReactNode; |
There was a problem hiding this comment.
It's interesting that TSLint is ok with 4-space indentation here and 2-space indentation everywhere else. Maybe that's just something it can't automatically --fix?
Sorry, something went wrong.
| }: ChipButtonProps) => { | ||
| return ( | ||
| <Button variant="plain" aria-label={ariaLabel} onClick={onClick} className={className} {...props}> | ||
| {children} |
There was a problem hiding this comment.
Hmm. Spacing here is still all messed up. I'll take a look at the config
Sorry, something went wrong.
|
Yeah, weirdly enough we have "indent": [true, "spaces", 2], in the tslint.json, but tslint seems to be ignoring it. yarn lint:ts | grep ChipButton error Command failed with exit code 2. ERROR: /Users/mturley/git/patternfly-react/packages/patternfly-4/react-core/src/components/ChipGroup/ChipButton.tsx:2:1 - Too many spaces after 'import' ERROR: /Users/mturley/git/patternfly-react/packages/patternfly-4/react-core/src/components/ChipGroup/ChipButton.tsx:2:32 - Too many spaces before 'from' |
Sorry, something went wrong.
|
Yikes. @redallen, this indent rule being broken is a bug that they just straight-up closed because TSLint is being deprecated. palantir/tslint#2814 Maybe that's reason enough to switch to tslint-plugin-prettier? at least until we switch to eslint |
Sorry, something went wrong.
Sorry, something went wrong.
What:
Closes #2362
cc @mturley
Additional issues: