Add issue template by rachael-phillips · Pull Request #2804 · patternfly/patternfly-react · GitHub

I would like to add an issue template for our contributors.

is this block needed?

No, I don't think so.

Suggested change

      
            ### Describe the issue. What are the expected and unexpected behavior categories?
          
            ### Describe the issue. Including the expected and unexpected behavior

Can we also add a question "is there a workaround?"

Yes, and maybe we wrap that into @redallen 's question about it being blocking. What about "If this issue is a bug, Is this issue blocking you or is there a work around?" cc @dgutride

I suggest we go with something closer to what React has. I've replaced "React" with "PatternFly" below and am open to feedback.

**Do you want to request a *feature* or report a *bug*?**

**What is the current behavior?**

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than PatternFly and React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:**

**What is the expected behavior?**

**Which versions of PatternFly, and which browser are affected by this issue? Did this work in previous versions of PatternFly?**

Then we could also add:

**If working on a Red Hat product, which product is this affecting and is there a workaround for now?**

Could also ask if this is blocking product work.

What do you think about this feedback @tlabaj ?

I think the wording here is what the team agreed upon. This give us more insight into an actual timeline for when the feature is needed.
cc @LHinson

I don't like this wording. As a dev, I'm not sure what a behaviour "category" is.

I think this question should be asked first and read like "Is this a bug or feature request?"

@redallen we chose this wording because we felt it was most helpful for users who may not know what a feature request is. cc @tlabaj @dgutride

Maybe "Is this a bug or an enhancement?"

I've updated the PatternFly issue template

Love it ❤️ .

Would be good to provide a ready-made environment that already pulls in PF etc

This is on my to-do list, especially with the -org refactor. You can add a followup issue and assign me!

This line needs to be commented. Also, please add this codesandbox link for people to easily reproduce issues: https://codesandbox.io/s/x2isc

What do you mean by it needs to be commented? It is just a general description of the template. I can add the link for sure.

I mean it needs to look like this:

<!-- Please populate the PatternFly issue template so we can learn more about your needs. Here's a codesandbox link you can reproduce your issue in: https://codesandbox.io/s/x2isc -->

The  makes it a comment that won't appear as plain text inside the issue.

LGTM

Update issue templates

3b960f9

I would like to add an issue template for our contributors.

rachael-phillips added the PF4 label Aug 30, 2019

rachael-phillips mentioned this pull request Aug 30, 2019

Add template to our issues #2788

Closed

rachael-phillips requested a review from redallen August 30, 2019 18:03

redallen changed the title Update issue templates Add issue template Aug 30, 2019

tlabaj suggested changes Aug 30, 2019

View reviewed changes

tlabaj reviewed Aug 30, 2019

View reviewed changes

redallen reviewed Aug 30, 2019

View reviewed changes

tlabaj added the chore 🏠 label Aug 30, 2019

tlabaj assigned redallen Aug 30, 2019

Update PatternFly template

847db21

I've updated the PatternFly issue template

redallen previously approved these changes Sep 20, 2019

View reviewed changes

jschuler reviewed Sep 20, 2019

View reviewed changes

Updated styling for the PF template

a97fb5b

rachael-phillips dismissed redallen’s stale review via a97fb5b October 22, 2019 19:18

tlabaj previously approved these changes Oct 22, 2019

View reviewed changes

redallen suggested changes Oct 22, 2019

View reviewed changes

Updated Zack's changes

70f4860

rachael-phillips dismissed tlabaj’s stale review via 70f4860 October 24, 2019 17:43

redallen previously approved these changes Oct 24, 2019

View reviewed changes

Add Codesandbox link

13f1792

redallen dismissed their stale review via 13f1792 October 24, 2019 17:49

Update codesandbox link

eac1109

redallen approved these changes Oct 24, 2019

View reviewed changes

tlabaj approved these changes Oct 24, 2019

View reviewed changes

tlabaj merged commit 22b3a6d into master Oct 24, 2019

redallen deleted the rachael-phillips-patch-1 branch March 3, 2020 20:46


		---

		### Describe the issue. What are the expected and unexpected behavior categories?

	### Describe the issue. What are the expected and unexpected behavior categories?
	### Describe the issue. Including the expected and unexpected behavior


		### Would you consider this issue a bug or enhancement?

		### What is your product and what release version are you targeting?


		### Please provide the steps to reproduce so we can better understand and address the issue. Feel free to link CodePen or another tool.

		### Would you consider this issue a bug or enhancement?


		### Describe the issue. What is the expected and unexpected behavior?

		### Please provide the steps to reproduce so we can better understand and address the issue. Feel free to link CodePen or another tool.

		@@ -0,0 +1,11 @@
		Please populate the PatternFly issue template so we can learn more about your needs.

		assignees: ''

		---

Add issue template by rachael-phillips · Pull Request #2804 · patternfly/patternfly-react · GitHub

Uh oh!

Add issue template - #2804

Add issue template#2804tlabaj merged 6 commits intomasterpatternfly/patternfly-react:masterfrom rachael-phillips-patch-1patternfly/patternfly-react:rachael-phillips-patch-1Copy head branch name to clipboard

Conversation

rachael-phillips commented Aug 30, 2019 • edited by tlabaj Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

redallen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

redallen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

redallen Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add issue template#2804
tlabaj merged 6 commits into
masterfrom
rachael-phillips-patch-1

rachael-phillips commented Aug 30, 2019 •
edited by tlabaj
Loading

redallen Oct 23, 2019 •
edited
Loading