fix(Select): display selections data properly - #2848
Merged
redallen merged 2 commits intoSep 18, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-2848.surge.sh |
Sorry, something went wrong.
redallen
suggested changes
Sep 6, 2019
Comment thread
packages/patternfly-4/react-core/src/components/Select/Select.tsx
Outdated
| }); | ||
| } | ||
|
|
||
| if (prevProps.selections !== this.props.selections) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Change to if (prevProps.selections !== this.props.selections && this.state.typeaheadActiveChild) {
Sorry, something went wrong.
Comment thread
packages/patternfly-4/react-core/src/components/Select/Select.tsx
Outdated
|
|
||
| if (prevProps.selections !== this.props.selections) { | ||
| this.setState({ | ||
| typeaheadInputValue: (this.state.typeaheadActiveChild && this.state.typeaheadActiveChild.innerText) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Change to typeaheadInputValue: this.state.typeaheadActiveChild.innerText.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks @redallen, moved check in the latest commit :) |
Sorry, something went wrong.
kmcfaul
approved these changes
Sep 18, 2019
kmcfaul
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good
Sorry, something went wrong.
redallen
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: This fixes selections prop being properly displayed if updated externally.
Additional issues: Fixes #2828